From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C271C19425 for ; Wed, 9 Dec 2020 10:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52E2C23B77 for ; Wed, 9 Dec 2020 10:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730150AbgLIKhf (ORCPT ); Wed, 9 Dec 2020 05:37:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:53608 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729964AbgLIKhe (ORCPT ); Wed, 9 Dec 2020 05:37:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 87C18AC94; Wed, 9 Dec 2020 10:36:52 +0000 (UTC) Date: Wed, 9 Dec 2020 11:36:49 +0100 From: Oscar Salvador To: David Hildenbrand Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails Message-ID: <20201209103649.GD30892@linux> References: <20201209092818.30417-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2020 at 10:59:04AM +0100, David Hildenbrand wrote: > On 09.12.20 10:28, Oscar Salvador wrote: > Do we expect callers to retry immediately? -EAGAIN might make also > sense. But -EBUSY is an obvious improvement. Do we have callers relying > on this behavior? Not really, unless something LTP takes a look at the error code in retries in case EBUSY. Take into account that most of the callers do not even really check the return code (GHES, RAS/CEC, etc.) -- Oscar Salvador SUSE L3