From: Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Ley Foon Tan <ley.foon.tan@intel.com>,
Mark Salter <msalter@redhat.com>,
Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
linux-c6x-dev@linux-c6x.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files
Date: Thu, 10 Dec 2020 06:18:44 +0000 [thread overview]
Message-ID: <20201210061844.GA21126@infradead.org> (raw)
In-Reply-To: <04828b4e-8791-6f3e-8984-9de06f40c85a@infradead.org>
On Wed, Dec 09, 2020 at 10:16:20PM -0800, Randy Dunlap wrote:
> include/asm-generic/local64.h has comments about some $arch could do
> its things better/faster instead of using asm-generic, but no $arch has
> done that since 2010 when it was added.
>
> Is that conclusive?
> If it is, why even use mandatory-y?
> Why not just change all occurrences of <asm/local64.h>
> to <asm-generic/local64.h> ?
asm-generic must not be included by non-arch code directly. So the
sensible options are either:
a) mark it as mandatory-y in include/asm-generic/Kbuild
b) rename it to linux/local64.h and fixup all references
a) seems much less invasive, but b) might be the better option long
term.
next prev parent reply other threads:[~2020-12-10 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 20:46 [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files Randy Dunlap
2020-12-10 1:55 ` Tan, Ley Foon
2020-12-10 6:07 ` Christoph Hellwig
2020-12-10 6:16 ` Randy Dunlap
2020-12-10 6:18 ` Christoph Hellwig [this message]
2020-12-10 8:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210061844.GA21126@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jacquiot.aurelien@gmail.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox