From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Elliot Berman <eberman@codeaurora.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: [kbuild] drivers/firmware/qcom_scm.c:181:12: warning: Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)'
Date: Thu, 10 Dec 2020 11:37:35 +0300 [thread overview]
Message-ID: <20201210083735.GK2789@kadam> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a2f5ea9e314ba6778f885c805c921e9362ec0420
commit: 57d3b816718c1cf832e2929a754da3564c6127cc firmware: qcom_scm: Remove thin wrappers
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/firmware/qcom_scm.c:181:12: warning: Redundant condition: cpus. '!cpus || (cpus && cpumask_empty(cpus))' is equivalent to '!cpus || cpumask_empty(cpus)' [redundantCondition]
if (!cpus || (cpus && cpumask_empty(cpus)))
^
vim +181 drivers/firmware/qcom_scm.c
65f0c90b7d4685 Elliot Berman 2020-01-07 164 int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
2ce76a6ad32fa0 Lina Iyer 2015-03-02 165 {
57d3b816718c1c Elliot Berman 2020-01-07 166 int flags = 0;
57d3b816718c1c Elliot Berman 2020-01-07 167 int cpu;
57d3b816718c1c Elliot Berman 2020-01-07 168 int scm_cb_flags[] = {
57d3b816718c1c Elliot Berman 2020-01-07 169 QCOM_SCM_FLAG_COLDBOOT_CPU0,
57d3b816718c1c Elliot Berman 2020-01-07 170 QCOM_SCM_FLAG_COLDBOOT_CPU1,
57d3b816718c1c Elliot Berman 2020-01-07 171 QCOM_SCM_FLAG_COLDBOOT_CPU2,
57d3b816718c1c Elliot Berman 2020-01-07 172 QCOM_SCM_FLAG_COLDBOOT_CPU3,
57d3b816718c1c Elliot Berman 2020-01-07 173 };
57d3b816718c1c Elliot Berman 2020-01-07 174 struct qcom_scm_desc desc = {
57d3b816718c1c Elliot Berman 2020-01-07 175 .svc = QCOM_SCM_SVC_BOOT,
57d3b816718c1c Elliot Berman 2020-01-07 176 .cmd = QCOM_SCM_BOOT_SET_ADDR,
57d3b816718c1c Elliot Berman 2020-01-07 177 .arginfo = QCOM_SCM_ARGS(2),
57d3b816718c1c Elliot Berman 2020-01-07 178 .owner = ARM_SMCCC_OWNER_SIP,
57d3b816718c1c Elliot Berman 2020-01-07 179 };
57d3b816718c1c Elliot Berman 2020-01-07 180
57d3b816718c1c Elliot Berman 2020-01-07 @181 if (!cpus || (cpus && cpumask_empty(cpus)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This could be written as: if (!cpus || cpumask_empty(cpus))
57d3b816718c1c Elliot Berman 2020-01-07 182 return -EINVAL;
57d3b816718c1c Elliot Berman 2020-01-07 183
57d3b816718c1c Elliot Berman 2020-01-07 184 for_each_cpu(cpu, cpus) {
57d3b816718c1c Elliot Berman 2020-01-07 185 if (cpu < ARRAY_SIZE(scm_cb_flags))
57d3b816718c1c Elliot Berman 2020-01-07 186 flags |= scm_cb_flags[cpu];
57d3b816718c1c Elliot Berman 2020-01-07 187 else
57d3b816718c1c Elliot Berman 2020-01-07 188 set_cpu_present(cpu, false);
57d3b816718c1c Elliot Berman 2020-01-07 189 }
57d3b816718c1c Elliot Berman 2020-01-07 190
57d3b816718c1c Elliot Berman 2020-01-07 191 desc.args[0] = flags;
57d3b816718c1c Elliot Berman 2020-01-07 192 desc.args[1] = virt_to_phys(entry);
57d3b816718c1c Elliot Berman 2020-01-07 193
57d3b816718c1c Elliot Berman 2020-01-07 194 return qcom_scm_call_atomic(__scm ? __scm->dev : NULL, &desc, NULL);
2ce76a6ad32fa0 Lina Iyer 2015-03-02 195 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
reply other threads:[~2020-12-10 8:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210083735.GK2789@kadam \
--to=dan.carpenter@oracle.com \
--cc=bjorn.andersson@linaro.org \
--cc=eberman@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox