Re: [PATCH v8 04/12] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page

Oscar Salvador
2020-12-10T14:57:03Z

On Thu, Dec 10, 2020 at 03:42:56PM +0100, Oscar Salvador wrote:
> On Thu, Dec 10, 2020 at 11:55:18AM +0800, Muchun Song wrote:
> > The free_vmemmap_pages_per_hpage() which indicate that how many vmemmap
> > pages associated with a HugeTLB page that can be freed to the buddy
> > allocator just returns zero now, because all infrastructure is not
> > ready. Once all the infrastructure is ready, we will rework this
> > function to support the feature.
>
> I would reword the above to:
>
> "free_vmemmap_pages_per_hpage(), which indicates how many vmemmap
> pages associated with a HugeTLB page can be freed, returns zero for
> now, which means the feature is disabled.
> We will enable it once all the infrastructure is there."
>
> Or something along those lines.
>
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> Overall this looks good to me, and it has seen a considerable
> simplification, which is good.
> Some nits/questions below:

And as I said, I would merge patch#3 with this one.

--
Oscar Salvador
SUSE L3