[PATCH 5.4 48/54] rtw88: debug: Fix uninitialized memory in debugfs code

Greg Kroah-Hartman
2020-12-10T14:42:29Z

From: Dan Carpenter <dan.carpenter@oracle.com>

commit 74a8c816fa8fa7862df870660e9821abb56649fe upstream.

This code does not ensure that the whole buffer is initialized and none
of the callers check for errors so potentially none of the buffer is
initialized. Add a memset to eliminate this bug.

Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/X8ilOfVz3pf0T5ec@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
drivers/net/wireless/realtek/rtw88/debug.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -146,6 +146,8 @@ static int rtw_debugfs_copy_from_user(ch
{
int tmp_len;

+ memset(tmp, 0, size);
+
if (count < num)
return -EFAULT;