Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding

Maxime Ripard
2020-12-14T10:38:59Z

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
>
> Add a new DT compatible for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 6db32fbf813f..73a6c8421172 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -700,6 +700,11 @@ properties:
> - const: pine64,pinetab
> - const: allwinner,sun50i-a64
>
> + - description: Pine64 PineTab with new LCD panel
> + items:
> + - const: pine64,pinetab-new-panel
> + - const: allwinner,sun50i-a64
> +

We're on the right track, but new panel seems a bit too vague. What is
going to happen when they will change the panel again?

pinetab-early-adopter seems more robust there

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]