From: Lee Jones <lee.jones@linaro.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon
Date: Fri, 11 Dec 2020 13:10:49 +0000 [thread overview]
Message-ID: <20201211131049.GE5029@dell> (raw)
In-Reply-To: <7416de308a9b41d3ac881210ab114159@AcuMS.aculab.com>
Why does your mailer thread emails?
Your reply is not detached from the remainder of the thread.
On Fri, 11 Dec 2020, David Laight wrote:
> From: Lee Jones
> > Sent: 11 December 2020 10:06
> >
> > On Fri, 11 Dec 2020, Zheng Yongjun wrote:
> >
> > > Replace a comma between expression statements by a semicolon.
> > >
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > ---
> > > drivers/mfd/rave-sp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> > > index 545196c85b5c..abb9cbdabaa9 100644
> > > --- a/drivers/mfd/rave-sp.c
> > > +++ b/drivers/mfd/rave-sp.c
> > > @@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
> > >
> > > ackid = atomic_inc_return(&sp->ackid);
> > > reply.ackid = ackid;
> > > - reply.code = rave_sp_reply_code((u8)command),
> > > + reply.code = rave_sp_reply_code((u8)command);
> >
> > How did the original code not create a build error?
>
> Nowt wrong with commas.
Well you learn something new every day!
> Why not go the other way.
> Convert almost all the ; to , and delete most of the { } in
> if and for statements (etc).
Sorry, I don't understand. Please elaborate/provide an example.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-11 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 11:14 bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon David Laight
2020-12-11 13:10 ` Lee Jones [this message]
2020-12-11 13:15 ` David Laight
2020-12-11 14:45 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211131049.GE5029@dell \
--to=lee.jones@linaro.org \
--cc=David.Laight@ACULAB.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox