From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing
Date: Fri, 11 Dec 2020 16:16:24 +0200 [thread overview]
Message-ID: <20201211141624.GQ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201210203318.6914-1-semen.protsenko@linaro.org>
On Thu, Dec 10, 2020 at 10:33:18PM +0200, Sam Protsenko wrote:
> If "port" node is missing in PHY controller node, dwc3_get_extcon()
> isn't able to find extcon device. This is perfectly fine in case when
> "usb-role-switch" or OTG is used, but next misleading error message is
> printed in that case, from of_graph_get_remote_node():
>
> OF: graph: no port node found in /phy@1234abcd
>
> Avoid printing that message by checking if port node exists in PHY node
> before calling of_graph_get_remote_node().
By some reason you have two separate messages (missed --thread when run `git
format-patch ...`?).
In any case I think it should be dropped or reworked and resent since patch 1/2
got comments.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-12 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 20:33 [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing Sam Protsenko
2020-12-11 14:16 ` Andy Shevchenko [this message]
2020-12-11 14:20 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211141624.GQ4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox