From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8CBBC433FE for ; Fri, 11 Dec 2020 16:29:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EADC22C9D for ; Fri, 11 Dec 2020 16:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404068AbgLKPcc (ORCPT ); Fri, 11 Dec 2020 10:32:32 -0500 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:36396 "EHLO gproxy5-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728097AbgLKPbi (ORCPT ); Fri, 11 Dec 2020 10:31:38 -0500 Received: from cmgw12.unifiedlayer.com (unknown [10.9.0.12]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 9E2B6140593 for ; Fri, 11 Dec 2020 08:30:52 -0700 (MST) Received: from bh-25.webhostbox.net ([208.91.199.152]) by cmsmtp with ESMTP id nkNgkuHgJeMJHnkNgkzYDw; Fri, 11 Dec 2020 08:30:52 -0700 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.3 cv=G/Ay7es5 c=1 sm=1 tr=0 a=QNED+QcLUkoL9qulTODnwA==:117 a=2cfIYNtKkjgZNaOwnGXpGw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=zTNgK-yGK50A:10:nop_rcvd_month_year a=evQFzbml-YQA:10:endurance_base64_authed_username_1 a=pGLkceISAAAA:8 a=8b9GpE9nAAAA:8 a=gXLdhW2jAAAA:8 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=4nLjXZC_2OsmtIj_7QcA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=T3LWEMljR5ZiDmsYVIUa:22 a=Dn9eIPSr_RzuO0KTJioD:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gd4TqXY4BSKjxy0wZAJmMYfgONf9xSwv+hR20bhHipY=; b=yajlItLy2oSatIUQgXKfDhVvqd OKHQycXXsPupYM4gKabd1CY2JWOUKxyMyv2eaBd7TAxZbG8J/emEpUR+i5Y4dUKTsTDDuMTnDiA+4 gU3sKynXxBm9NRl3pTAkUu1ibQ6kzZkYCa1w+6KkXMOolkSohb5SGhRf2SU7mvvYK3KZx5owawE7N thYImYgU0PbXOdLes150gu+OLbFeIYdxeqVEmE8QhzUBN6tdh97C6ujbHgXPaACb9EJb9GoiNzzwq h0ZVLx9huqwTN68WMnmquSt3xFD53vuEfFpe8L9IgHXG2K2/MpSSKWytqxVFGsTPyXXiY0HdDE2gp rNngIAQg==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:41724 helo=localhost) by bh-25.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1knkNf-003Xqj-K0; Fri, 11 Dec 2020 15:30:51 +0000 Date: Fri, 11 Dec 2020 07:30:50 -0800 From: Guenter Roeck To: Charles Hsu Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, alan@redhat.com Subject: Re: [PATCH v6] hwmon: Add driver for STMicroelectronics PM6764 Voltage Regulator. Message-ID: <20201211153050.GA74106@roeck-us.net> References: <20201211094605.270734-1-hsu.yungteng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201211094605.270734-1-hsu.yungteng@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-BWhitelist: no X-Source-IP: 108.223.40.66 X-Source-L: No X-Exim-ID: 1knkNf-003Xqj-K0 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 108-223-40-66.lightspeed.sntcca.sbcglobal.net (localhost) [108.223.40.66]:41724 X-Source-Auth: guenter@roeck-us.net X-Email-Count: 11 X-Source-Cap: cm9lY2s7YWN0aXZzdG07YmgtMjUud2ViaG9zdGJveC5uZXQ= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 05:46:05PM +0800, Charles Hsu wrote: > The output voltage use the MFR_READ_VOUT 0xD4 > Vout value returned is linear11. > > Signed-off-by: Charles Hsu I'll keep the patch I already applied, with all the _compile_ problems fixed. Please check out hwmon-next and submit follow-up patches if needed. Guenter > --- > v6: > - Fix misspelling. > v5: > - Add MAINTAINERS. > v4: > - Add pm6764tr to Documentation/hwmon/index.rst. > v3: > - Add Documentation(Documentation/hwmon/pm6764tr.rst). > - Fix include order. > v2: > - Fix formatting. > - Remove pmbus_do_remove. > - Change from .probe to .probe_new. > v1: > - Initial patchset. > --- > Documentation/hwmon/index.rst | 1 + > Documentation/hwmon/pm6764tr.rst | 32 ++++++++++++++ > MAINTAINERS | 7 +++ > drivers/hwmon/pmbus/Kconfig | 9 ++++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/pm6764tr.c | 76 ++++++++++++++++++++++++++++++++ > 6 files changed, 126 insertions(+) > create mode 100644 Documentation/hwmon/pm6764tr.rst > create mode 100644 drivers/hwmon/pmbus/pm6764tr.c > > diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst > index b797db738225..b3ed0047543b 100644 > --- a/Documentation/hwmon/index.rst > +++ b/Documentation/hwmon/index.rst > @@ -144,6 +144,7 @@ Hardware Monitoring Kernel Drivers > pc87360 > pc87427 > pcf8591 > + pm6764 > pmbus > powr1220 > pxe1610 > diff --git a/Documentation/hwmon/pm6764tr.rst b/Documentation/hwmon/pm6764tr.rst > new file mode 100644 > index 000000000000..4681780d3f0d > --- /dev/null > +++ b/Documentation/hwmon/pm6764tr.rst > @@ -0,0 +1,32 @@ > +.. SPDX-License-Identifier: GPL-2.0-only > + > +Kernel driver pm6764tr > +====================== > + > +Supported chips: > + > + * ST PM6764TR > + > + Prefix: 'pm6764tr' > + > + Addresses scanned: - > + > + Datasheet: http://www.st.com/resource/en/data_brief/pm6764.pdf > + > +Authors: > + > + > +Description: > +------------ > + > +This driver supports the STMicroelectronics PM6764TR chip. The PM6764TR is a high > +performance digital controller designed to power Intel’s VR12.5 processors and memories. > + > +The device utilizes digital technology to implement all control and power management > +functions to provide maximum flexibility and performance. The NVM is embedded to store > +custom configurations. The PM6764TR device features up to 4-phase programmable operation. > + > +The PM6764TR supports power state transitions featuring VFDE, and programmable DPM > +maintaining the best efficiency over all loading conditions without compromising transient > +response. The device assures fast and independent protection against load overcurrent, > +under/overvoltage and feedback disconnections. > diff --git a/MAINTAINERS b/MAINTAINERS > index 2daa6ee673f7..0456a2101622 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13893,6 +13893,13 @@ M: Logan Gunthorpe > S: Maintained > F: drivers/dma/plx_dma.c > > +PM6764TR DRIVER > +M: Charles Hsu > +L: linux-hwmon@vger.kernel.org > +S: Maintained > +F: Documentation/hwmon/pm6764tr.rst > +F: drivers/hwmon/pmbus/pm6764tr.c > + > PM-GRAPH UTILITY > M: "Todd E Brandt" > L: linux-pm@vger.kernel.org > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig > index a25faf69fce3..9c846facce9f 100644 > --- a/drivers/hwmon/pmbus/Kconfig > +++ b/drivers/hwmon/pmbus/Kconfig > @@ -220,6 +220,15 @@ config SENSORS_MP2975 > This driver can also be built as a module. If so, the module will > be called mp2975. > > +config SENSORS_PM6764TR > + tristate "ST PM6764TR" > + help > + If you say yes here you get hardware monitoring support for ST > + PM6764TR. > + > + This driver can also be built as a module. If so, the module will > + be called pm6764tr. > + > config SENSORS_PXE1610 > tristate "Infineon PXE1610" > help > diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile > index 4c97ad0bd791..31ebdef5d4a6 100644 > --- a/drivers/hwmon/pmbus/Makefile > +++ b/drivers/hwmon/pmbus/Makefile > @@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785) += max31785.o > obj-$(CONFIG_SENSORS_MAX34440) += max34440.o > obj-$(CONFIG_SENSORS_MAX8688) += max8688.o > obj-$(CONFIG_SENSORS_MP2975) += mp2975.o > +obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o > obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o > obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o > obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o > diff --git a/drivers/hwmon/pmbus/pm6764tr.c b/drivers/hwmon/pmbus/pm6764tr.c > new file mode 100644 > index 000000000000..9531f370d7df > --- /dev/null > +++ b/drivers/hwmon/pmbus/pm6764tr.c > @@ -0,0 +1,76 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Hardware monitoring driver for STMicroelectronics digital controller PM6764TR > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include "pmbus.h" > + > +#define PM6764TR_PMBUS_READ_VOUT 0xD4 > + > +static int pm6764tr_read_word_data(struct i2c_client *client, int page, int reg) > +{ > + int ret; > + > + switch (reg) { > + case PMBUS_VIRT_READ_VMON: > + ret = pmbus_read_word_data(client, page, PM6764TR_PMBUS_READ_VOUT); > + break; > + default: > + ret = -ENODATA; > + break; > + } > + return ret; > +} > + > +static struct pmbus_driver_info pm6764tr_info = { > + .pages = 1, > + .format[PSC_VOLTAGE_IN] = linear, > + .format[PSC_VOLTAGE_OUT] = vid, > + .format[PSC_TEMPERATURE] = linear, > + .format[PSC_CURRENT_OUT] = linear, > + .format[PSC_POWER] = linear, > + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | > + PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON | > + PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT | > + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP, > + .read_word_data = pm6764tr_read_word_data, > +}; > + > +static int pm6764tr_probe(struct i2c_client *client, > + const struct i2c_device_id *id) > +{ > + return pmbus_do_probe(client, id, &pm6764tr_info); > +} > + > +static const struct i2c_device_id pm6764tr_id[] = { > + {"pm6764tr", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, pm6764tr_id); > + > +static const struct of_device_id pm6764tr_of_match[] = { > + {.compatible = "st,pm6764tr"}, > + {} > +}; > + > +/* This is the driver that will be inserted */ > +static struct i2c_driver pm6764tr_driver = { > + .driver = { > + .name = "pm6764tr", > + .of_match_table = of_match_ptr(pm6764tr_of_match), > + }, > + .probe_new = pm6764tr_probe, > + .id_table = pm6764tr_id, > +}; > + > +module_i2c_driver(pm6764tr_driver); > + > +MODULE_AUTHOR("Charles Hsu"); > +MODULE_DESCRIPTION("PMBus driver for ST PM6764TR"); > +MODULE_LICENSE("GPL");