arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler'

arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Hi Mark,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2c85ebc57b3e1817b6ce1a6b703928e113a90442
commit: ed3768db588291ddb5dc794daed12cc751373566 arm64: entry: convert el1_sync to C
date:   1 year, 2 months ago
config: arm64-randconfig-r021-20201214 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed3768db588291ddb5dc794daed12cc751373566
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout ed3768db588291ddb5dc794daed12cc751373566
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler' [-Wmissing-prototypes]
      68 | asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
         |                         ^~~~~~~~~~~~~~~~

vim +/el1_sync_handler +68 arch/arm64/kernel/entry-common.c

    67	
  > 68	asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41120 bytes --]

Re: arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler'

[Catalin Marinas]

On Mon, Dec 14, 2020 at 03:12:34PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   2c85ebc57b3e1817b6ce1a6b703928e113a90442
> commit: ed3768db588291ddb5dc794daed12cc751373566 arm64: entry: convert el1_sync to C
> date:   1 year, 2 months ago
> config: arm64-randconfig-r021-20201214 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed3768db588291ddb5dc794daed12cc751373566
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout ed3768db588291ddb5dc794daed12cc751373566
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler' [-Wmissing-prototypes]
>       68 | asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)

Do we actually need to fix these? It's asmlinkage and called from
assembly, it wouldn't understand a prototype anyway.

-- 
Catalin

Re: arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler'

[Mark Rutland]

On Mon, Dec 14, 2020 at 10:28:48AM +0000, Catalin Marinas wrote:
> On Mon, Dec 14, 2020 at 03:12:34PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   2c85ebc57b3e1817b6ce1a6b703928e113a90442
> > commit: ed3768db588291ddb5dc794daed12cc751373566 arm64: entry: convert el1_sync to C
> > date:   1 year, 2 months ago
> > config: arm64-randconfig-r021-20201214 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed3768db588291ddb5dc794daed12cc751373566
> >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >         git fetch --no-tags linus master
> >         git checkout ed3768db588291ddb5dc794daed12cc751373566
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> arch/arm64/kernel/entry-common.c:68:25: warning: no previous prototype for 'el1_sync_handler' [-Wmissing-prototypes]
> >       68 | asmlinkage void notrace el1_sync_handler(struct pt_regs *regs)
> 
> Do we actually need to fix these? It's asmlinkage and called from
> assembly, it wouldn't understand a prototype anyway.

Given we do this for a few other asmlinkage functions in this area, I'll
spin a patch to add the few missing entry-common.c prototypes to
asm/exception.h for consistency.

It's not strictly necessary, but it's vastly less effort than fighting
the testing systems. ;)

Thanks,
Mark.