Re: [PATCH 03/15] perf: Add build id data in mmap2 event

Daniel Borkmann
2020-12-15T22:03:14Z

Hey Arnaldo,

On 12/15/20 4:52 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 14, 2020 at 11:54:45AM +0100, Jiri Olsa escreveu:
>> Adding support to carry build id data in mmap2 event.
>>
>> The build id data replaces maj/min/ino/ino_generation
>> fields, which are also used to identify map's binary,
>> so it's ok to replace them with build id data:
>>
>> union {
>> struct {
>> u32 maj;
>> u32 min;
>> u64 ino;
>> u64 ino_generation;
>> };
>> struct {
>> u8 build_id_size;
>> u8 __reserved_1;
>> u16 __reserved_2;
>> u8 build_id[20];
>> };
>> };
>
> Alexei/Daniel, this one depends on BPFs build id routines to be exported
> for use by the perf kernel subsys, PeterZ already acked this, so can you
> guys consider getting the first three patches in this series via the bpf
> tree?
>
> The BPF bits were acked by Song.

All the net-next and therefore also bpf-next bits for 5.11 were just merged
by Linus into his tree. If you need the first 3 from [0] to land for this merge
window, it's probably easiest if you take them in and send them via perf tree
directly in case you didn't send out a pull-req yet.. (alternatively I'll ping
David/Jakub if they plan to make a 2nd net-next pull-req end of this week).

Thanks,
Daniel

[0] https://lore.kernel.org/lkml/20201214105457.543111-1-jolsa@kernel.org/