From: Mark Brown <broonie@kernel.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org,
bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state
Date: Mon, 14 Dec 2020 17:50:09 +0000 [thread overview]
Message-ID: <20201214175009.GD4880@sirena.org.uk> (raw)
In-Reply-To: <89456f01-aa02-7a7d-a47b-bf1f26e66d4c@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote:
> On 12/1/2020 11:21 PM, Mark Brown wrote:
> > > Later from review comments by Srinivas kandagatla, I got to know
> > >
> > > about regcache sync APIs, which can be used to sync cache after resume and
> > >
> > > HW registers can be updated with original values. With that playback can be
> > > continued.
> > > So is the reason, I am reverting partial changes in the commit b1824968221c.
> > I don't understand why a fix for the register cache not being in sync
> > with the hardware doesn't involve syncing the register cache with the
> > hardware.
> I am sorry I couldn't understand your point. Could you please elaborate your
> query?
Your changelog talks about syncing the cache but neither the driver nor
your change actually does that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-14 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 4:59 [PATCH v4 0/2] Platform driver update to support playback recover after resume Srinivasa Rao Mandadapu
2020-11-28 4:59 ` [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state Srinivasa Rao Mandadapu
2020-11-30 11:09 ` Srinivas Kandagatla
2020-11-30 12:46 ` Mark Brown
2020-12-01 17:31 ` Srinivasa Rao Mandadapu
2020-12-01 17:51 ` Mark Brown
2020-12-14 12:43 ` Srinivasa Rao Mandadapu
2020-12-14 17:50 ` Mark Brown [this message]
2020-12-17 8:14 ` Srinivasa Rao Mandadapu
2020-12-17 8:18 ` Srinivasa Rao Mandadapu
2020-11-28 4:59 ` [PATCH v4 2/2] ASoC: qcom: Add support for playback recover after resume Srinivasa Rao Mandadapu
2020-11-30 11:19 ` Srinivas Kandagatla
2020-11-30 16:26 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214175009.GD4880@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox