From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, mturquette@baylibre.com, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v1 0/1] add support for the LMK04832
Date: Mon, 14 Dec 2020 19:44:19 -0500 [thread overview]
Message-ID: <20201215004420.11342-1-liambeguin@gmail.com> (raw)
From: Liam Beguin <lvb@xiphos.com>
Hi,
The LMK04832 is an ultra-high performance clock conditioner with JEDEC
JESD204B support and is also pin compatible with the LMK0482x family of
devices.
This driver adds minimal support to configure the LMK04832 clocks using
the clock framework.
At the moment, this doesn't fully support JESD204B subclass 1.
I'm working on adding proper SYSREF support and will update this series
as soon as it's ready.
At this stage, I was hoping for some general feedback on the work done
so far and advice on a few points:
- Currently, nothing sets the VCO frequency. In a local version,
I used a devicetree property and clk_set_rate(lmk->vco.clk, vco_rate).
Should this be set using the parent_rate from inside the
lmk04832_sclk_round_rate() and lmk04832_dclk_round_rate() functions.
How would this affect VCO sub clocks?
- Should round_rate error out when the calculated rate is too far from
the desired rate? Other drivers don't seem to do that.
- Since this is device is compatible with the LMK0482x family, should
the driver be renamed to lmk048xx?
Thanks for your time,
Liam
Liam Beguin (1):
clk: add initial support for the lmk04832
.../devicetree/bindings/clock/ti,lmk04832.txt | 90 ++
drivers/clk/Kconfig | 7 +
drivers/clk/Makefile | 1 +
drivers/clk/clk-lmk04832.c | 1357 +++++++++++++++++
4 files changed, 1455 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/ti,lmk04832.txt
create mode 100644 drivers/clk/clk-lmk04832.c
base-commit: 2c85ebc57b3e1817b6ce1a6b703928e113a90442
--
2.27.0
next reply other threads:[~2020-12-15 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 0:44 Liam Beguin [this message]
2020-12-15 0:44 ` [RFC PATCH v1 1/1] clk: add initial support for the lmk04832 Liam Beguin
2021-02-12 4:08 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215004420.11342-1-liambeguin@gmail.com \
--to=liambeguin@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox