From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916A0C2BBCA for ; Wed, 16 Dec 2020 09:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D01723104 for ; Wed, 16 Dec 2020 09:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbgLPJDC (ORCPT ); Wed, 16 Dec 2020 04:03:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbgLPJDB (ORCPT ); Wed, 16 Dec 2020 04:03:01 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C14C0613D6 for ; Wed, 16 Dec 2020 01:02:21 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id q75so1647708wme.2 for ; Wed, 16 Dec 2020 01:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FWvCYlZeHvTxLAz8vqKtVr/s/CrDMueKsSBlUuHF038=; b=ZVg/fQwwPlgfRWzWYIdZRkw7KTosGTnGGAagJAXpartiAIQ+TKyw2RabIOsuagIxrf WM7wAkSDezZKZOCZKPLg7zjD+Mk2KoRM1WJQVLjQrspL0oyT5u7UmbeIn+8jiYhmMgGn fv2ISwDLHCNykWFAFB4wat3WGNVoDX+ao4lQM0vvk1iweizruS40HywStuduF3hBPCtu kKLelaSPkE30iyOka10aUw7KWLWP8e9LIrah1oD6lAEk3zjZ2KZrmzO7NDe4K2iimNfI cPYixcji+RmRNrg4g7bH50zNajE5LyyXayyDF6oU6I0+4+GMaGD9Gt9NdkA6vQtCe3n/ cCdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FWvCYlZeHvTxLAz8vqKtVr/s/CrDMueKsSBlUuHF038=; b=prep0ON8cWOOPdHMpD8XVdI+R5hOzm6tnnM7OwfrVJRKE2Gd0c/n0hA6BkI9cfTXfd KtYvscX2pBOMBiRf7UTE6t0/GvQ7QQhNJd1/2S2DidHEt7k0Xy8DKI1XjhtuRU5rvYAV lLKC6L3Gol/3ho5z3/90UKlfU6xlTCvaWqFkrnxtnnXlDw00hRD+DRA0wm0lH+LteovZ eeu6QACsao0gvMmfVRCYBUh2WpFUVyoOC4dq07oGECuIQtSf5lvQWSjjw5zTDR93R5iS ceLTljLb67HxLq2IH0s0VBCTpD1C/hFeebS5o9UPgYgZrEsNSG70655CzmgzWiGzVz+l 2Sog== X-Gm-Message-State: AOAM531pL/jZzHOE4eTa8VKn0cOJrs4CNO6mBA7SaRRq4dxUlP5JcZIZ 06vbrAPl105oLM1h2Ma1XuUUBg== X-Google-Smtp-Source: ABdhPJw6R7Z4nW7a8kYNXv2QcariaxDSBMTL4lMnIGxjItNgV3+WYaUuN2zmT6kT6ySCF1fc39Lp6w== X-Received: by 2002:a1c:43c5:: with SMTP id q188mr2225355wma.163.1608109340195; Wed, 16 Dec 2020 01:02:20 -0800 (PST) Received: from dell ([91.110.221.200]) by smtp.gmail.com with ESMTPSA id c1sm1741920wml.8.2020.12.16.01.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 01:02:19 -0800 (PST) Date: Wed, 16 Dec 2020 09:02:17 +0000 From: Lee Jones To: "Vaittinen, Matti" Cc: "lgirdwood@gmail.com" , "marek.vasut+renesas@gmail.com" , "yoshihiro.shimoda.uh@renesas.com" , "broonie@kernel.org" , "bgolaszewski@baylibre.com" , "linus.walleij@linaro.org" , linux-power , "linux-gpio@vger.kernel.org" , "khiem.nguyen.xt@renesas.com" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF Message-ID: <20201216090217.GB207743@dell> References: <1608104275-13174-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1608104275-13174-13-git-send-email-yoshihiro.shimoda.uh@renesas.com> <6937e03fd87f12925d904c2cad0cf665efdc895f.camel@fi.rohmeurope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6937e03fd87f12925d904c2cad0cf665efdc895f.camel@fi.rohmeurope.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Dec 2020, Vaittinen, Matti wrote: > > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the support of new PMIC to existing bd9571mwv driver. > > > > Signed-off-by: Khiem Nguyen > > [shimoda: rebase and refactor] > > Signed-off-by: Yoshihiro Shimoda > > Reviewed-by: Matti Vaittinen > > > --- > > drivers/mfd/bd9571mwv.c | 86 > > ++++++++++++++++++++++++++++++++++++++++++- > > include/linux/mfd/bd9571mwv.h | 18 +++++++-- > > 2 files changed, 99 insertions(+), 5 deletions(-) ... and please snip long replies. Scrolling down past lots of un-reviewed code and/or past the end of the last review comment is a waste of people's time. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog