From: Catalin Marinas <catalin.marinas@arm.com>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, will@kernel.org, yj.chiang@mediatek.com
Subject: Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION
Date: Wed, 16 Dec 2020 15:58:20 +0000 [thread overview]
Message-ID: <20201216155820.GH2511@gaia> (raw)
In-Reply-To: <20201125114130.507-1-lecopzer.chen@mediatek.com>
On Wed, Nov 25, 2020 at 07:41:30PM +0800, Lecopzer Chen wrote:
> >> In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION
> >> default is y if ACPI isn't configured.
> >
> >I'm a bit confused why this should be enabled for !ACPI. Which DT
> >platforms need this, and how do they use it? Why should this only be
> >enabled for kernels without ACPI support, and not for kernels that
> >support both ACPI and DT?
>
> In our internal patch has no !ACPI here,
> the reason I add here is that in kernel document[1] it mention:
> > No, sorry, you cannot have both ACPI and APM enabled and running at once.
> Thus, I try to limit the scope for who don't use the ACPI because I'm not sure
> they could exist at the same time or not.
>
> But I think it should be fine without !ACPI if APM and APCI
> config won't conflict with each other.
>
> So if it's better to remove !ACPI I'll send v2 for this.
>
> BTW, The platform is for our internal kernel drivers, they utilize APM interface,
> /dev/apm_bios to do their works in arm64.
Sorry, I don't think the APM interface makes sense on an arm64 kernel
(and it's also used by an out of tree driver).
--
Catalin
next prev parent reply other threads:[~2020-12-16 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:01 [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION Lecopzer Chen
2020-11-25 10:36 ` Mark Rutland
2020-11-25 11:41 ` Lecopzer Chen
2020-12-16 15:58 ` Catalin Marinas [this message]
2020-12-16 16:41 ` Lecopzer Chen
2020-12-17 16:49 ` Catalin Marinas
2020-12-18 5:02 ` Lecopzer Chen
2020-12-14 9:28 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216155820.GH2511@gaia \
--to=catalin.marinas@arm.com \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=will@kernel.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox