From: Guenter Roeck <linux@roeck-us.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jean Delvare <jdelvare@suse.com>, Kun Yi <kunyi@google.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86
Date: Wed, 16 Dec 2020 08:31:03 -0800 [thread overview]
Message-ID: <20201216163103.GA59351@roeck-us.net> (raw)
On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> about this driver when configuring a kernel without AMD X86 platform
> support.
>
> Fixes: e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Makes sense. Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
> config SENSORS_SBTSI
> tristate "Emulated SB-TSI temperature sensor"
> depends on I2C
> + depends on X86 || COMPILE_TEST
> help
> If you say yes here you get support for emulated temperature
> sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
> --
> 2.25.1
>
next reply other threads:[~2020-12-16 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 16:31 Guenter Roeck [this message]
2020-12-16 17:27 ` [PATCH] hwmon: SENSORS_SBTSI should depend on X86 Kun Yi
2020-12-16 20:17 ` Guenter Roeck
2020-12-17 8:07 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 13:46 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216163103.GA59351@roeck-us.net \
--to=linux@roeck-us.net \
--cc=geert@linux-m68k.org \
--cc=jdelvare@suse.com \
--cc=kunyi@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox