From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 951C3C2BBD4 for ; Fri, 18 Dec 2020 12:02:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CF9223A82 for ; Fri, 18 Dec 2020 12:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgLRMCZ (ORCPT ); Fri, 18 Dec 2020 07:02:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:54180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbgLRMCY (ORCPT ); Fri, 18 Dec 2020 07:02:24 -0500 Date: Fri, 18 Dec 2020 13:01:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608292904; bh=K6CUqnb/X7ZPJUEKfo8tMazAcE7KHIZB4MD6YANo84A=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=CM3Sg7wZQ3UhDO5QNEmg1lmWfQiLMKbGnFjcc9E11TJH2ThuGm1DAKMtm0ANW0vr8 6cSlJyaBZrKSrIl9ed9qSDvYkcaRYwu60KJWVhKiIB76fxd+GEV5XM6vBeeWVqIsae y7xSCBrxxdBKSsdbIoYNLigeU31UaNaTl6jwos6ncHFLLrq+1cpPDIDYWI5yjtyG0I hQpyNDVBb+JQyhoSRzOXuJGawDRVJY+uV2wrTPHkISTytFIRbUcUajOtpvUNSBJMHA Jp327LnjsOGIbsEGWzegyLkaWMZuH/x1Ne+HAaX/x4KZaaF7OX8N1i4TXyZ7S3kAaG usenRY5bBSrfA== From: Jessica Yu To: Will McVicker Cc: Masahiro Yamada , Michal Marek , Greg Kroah-Hartman , Christoph Hellwig , Saravana Kannan , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4] modules: introduce the MODULE_SCMVERSION config Message-ID: <20201218120138.GA5265@linux-8ccs> References: <20201216220850.659584-1-willmcvicker@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201216220850.659584-1-willmcvicker@google.com> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Will McVicker [16/12/20 22:08 +0000]: >Config MODULE_SCMVERSION introduces a new module attribute -- >`scmversion` -- which can be used to identify a given module's SCM >version. This is very useful for developers that update their kernel >independently from their kernel modules or vice-versa since the SCM >version provided by UTS_RELEASE (`uname -r`) will now differ from the >module's vermagic attribute. > >For example, we have a CI setup that tests new kernel changes on the >hikey960 and db845c devices without updating their kernel modules. When >these tests fail, we need to be able to identify the exact device >configuration the test was using. By including MODULE_SCMVERSION, we can >identify the exact kernel and modules' SCM versions for debugging the >failures. > >Additionally, by exposing the SCM version via the sysfs node >/sys/module/MODULENAME/scmversion, one can also verify the SCM versions >of the modules loaded from the initramfs. Currently, modinfo can only >retrieve module attributes from the module's ko on disk and not from the >actual module that is loaded in RAM. > >You can retrieve the SCM version in two ways, > >1) By using modinfo: > > modinfo -F scmversion MODULENAME >2) By module sysfs node: > > cat /sys/module/MODULENAME/scmversion > >Signed-off-by: Will McVicker Hi Will, thanks for v4. I'm on vacation for the next two weeks and with the current merge window almost over, I hope it'd be OK with you if we revisit this early January. Just wanted to give you a heads up. Thanks and happy holidays! Jessica