From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D8EC433E0 for ; Mon, 21 Dec 2020 14:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CF9722C7B for ; Mon, 21 Dec 2020 14:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbgLUOni (ORCPT ); Mon, 21 Dec 2020 09:43:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:56948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbgLUOni (ORCPT ); Mon, 21 Dec 2020 09:43:38 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4306822BEF; Mon, 21 Dec 2020 14:42:56 +0000 (UTC) Date: Mon, 21 Dec 2020 14:42:55 +0000 From: Jonathan Cameron To: Matt Ranostay Cc: Max Leiter , "open list:IIO SUBSYSTEM AND DRIVERS" , blaz@mxxn.io, Lars-Peter Clausen , Peter Meerwald-Stadler , Alexandru Ardelean , open list Subject: Re: [PATCH] iio:light:apds9960 add detection for MSHW0184 ACPI device in apds9960 driver Message-ID: <20201221144255.5657887f@archlinux> In-Reply-To: References: <20201220015057.107246-1-maxwell.leiter@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Dec 2020 14:05:17 -0800 Matt Ranostay wrote: > On Sat, Dec 19, 2020 at 5:51 PM Max Leiter wrote: > > > > The device is used in the Microsoft Surface Book 3 and Surface Pro 7 > > > > Signed-off-by: Max Leiter > > Reviewed-by: Matt Ranostay Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything. Thanks, Jonathan > > > --- > > drivers/iio/light/apds9960.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c > > index 9afb3fcc74e6..20719141c03a 100644 > > --- a/drivers/iio/light/apds9960.c > > +++ b/drivers/iio/light/apds9960.c > > @@ -8,6 +8,7 @@ > > * TODO: gesture + proximity calib offsets > > */ > > > > +#include > > #include > > #include > > #include > > @@ -1113,6 +1114,12 @@ static const struct i2c_device_id apds9960_id[] = { > > }; > > MODULE_DEVICE_TABLE(i2c, apds9960_id); > > > > +static const struct acpi_device_id apds9960_acpi_match[] = { > > + { "MSHW0184" }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(acpi, apds9960_acpi_match); > > + > > static const struct of_device_id apds9960_of_match[] = { > > { .compatible = "avago,apds9960" }, > > { } > > @@ -1124,6 +1131,7 @@ static struct i2c_driver apds9960_driver = { > > .name = APDS9960_DRV_NAME, > > .of_match_table = apds9960_of_match, > > .pm = &apds9960_pm_ops, > > + .acpi_match_table = apds9960_acpi_match, > > }, > > .probe = apds9960_probe, > > .remove = apds9960_remove, > > -- > > 2.29.2 > >