Re: [PATCH AUTOSEL 5.4 075/130] net/lapb: fix t1 timer handling for LAPB_STATE_0

Martin Schiller
2021-01-06T07:34:57Z

On 2020-12-24 10:49, Xie He wrote:
> On Wed, Dec 23, 2020 at 9:01 AM Xie He <xie.he.0141@gmail.com> wrote:
>>
>> I don't think this patch is suitable for stable branches. This patch
>> is
>> part of a patch series that changes the lapb module from "establishing
>> the
>> L2 connection only when needed by L3", to "establishing the L2
>> connection
>> automatically whenever we are able to". This is a behavioral change.
>> It
>> should be seen as a new feature. It is not a bug fix.
>
> Applying this patch without other patches in the same series will also
> introduce problems, because this patch relies on part of the changes
> in the subsequent patch in the same series to be correct.
>
> Hi Martin,
>
> It's better that we avoid using words like "fix" in non-bug-fix
> patches, and make every patch work on its own without subsequent
> patches. Otherwise we'll make people confused.

Yes, you are right.