From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1666C433E0 for ; Mon, 28 Dec 2020 03:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92C2C21D81 for ; Mon, 28 Dec 2020 03:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726552AbgL1DTw (ORCPT ); Sun, 27 Dec 2020 22:19:52 -0500 Received: from smtp2.axis.com ([195.60.68.18]:41023 "EHLO smtp2.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgL1DTu (ORCPT ); Sun, 27 Dec 2020 22:19:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1609125590; x=1640661590; h=from:to:cc:subject:mime-version: content-transfer-encoding:message-id:date; bh=6J3/haCJ1S4udfL+2NKVZM/qxvY7zBWBBCGW8TDBFh0=; b=Cuz5xMXH05qFVAGPTAlN15bImnLNqRm05MiRhMWGMu+iciT7O2ktorJg a/Gca7Uty1zIGswI/JZqgeb0OVznhlfhydf8aPs8m67PqYeqCQhgS+RuX yLarXlhTkl1aN7S38IVyQ4FZo3/u+yKZZJ3sXpBEAY6UKDvg6pTPxuVFq d45bYrZn0NPBuuWkzJ/Y2SGZ3455oAnpxUU/NizNE+LXdSh8KQb0zSi+S M6wzUYgVqfqe1TOq2ULEIevvG6fDFkgPgOq9cisbkBBh8jdXK2mZCYP7w mcietoLbiVFFwKyCnHOhvcmVTqvbuY8bUyIZ6dtWhNccboaHWOUwWlytE Q==; From: Hans-Peter Nilsson To: CC: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Ian Rogers Subject: [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20201228031908.B049B203B5@pchp3.se.axis.com> Date: Mon, 28 Dec 2020 04:19:08 +0100 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org That is, instead of "Lowering default frequency rate to " say "Lowering default frequency rate from to ", specifying the overridden default frequency , so you don't have to grep through the source to "remember" that was e.g. 4000. Signed-off-by: Hans-Peter Nilsson Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Adrian Hunter Cc: Kan Liang Cc: Ian Rogers --- tools/perf/util/record.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c index 07e4b96a6625..3b38e7be10da 100644 --- a/tools/perf/util/record.c +++ b/tools/perf/util/record.c @@ -202,10 +202,10 @@ static int record_opts__config_freq(struct record_opts *opts) * Default frequency is over current maximum. */ if (max_rate < opts->freq) { - pr_warning("Lowering default frequency rate to %u.\n" + pr_warning("Lowering default frequency rate from %u to %u.\n" "Please consider tweaking " "/proc/sys/kernel/perf_event_max_sample_rate.\n", - max_rate); + opts->freq, max_rate); opts->freq = max_rate; } -- 2.11.0 brgds, H-P