public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH V1] nohz: exit nohz idle before invoking softirq
@ 2020-12-28  3:47 chenshiyan
  2020-12-28 13:28 ` Frederic Weisbecker
  2020-12-29  8:39 ` [nohz] 7dbadb2bd2: WARNING:at_kernel/time/tick-sched.c:#tick_nohz_idle_exit kernel test robot
  0 siblings, 2 replies; 3+ messages in thread
From: chenshiyan @ 2020-12-28  3:47 UTC (permalink / raw)
  To: fweisbec, tglx, mingo, linux-kernel

From: "shiyan.csy" <shiyan.csy@alibaba-inc.com>

exit nohz idle before invoking softirq, or it maymiss
some ticks during softirq.

Signed-off-by: Shiyan Chen <chenshiyan@linux.alibaba.com>
---
 kernel/softirq.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9d71046..59bd6fe 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -404,6 +404,10 @@ static inline void tick_irq_exit(void)
 		if (!in_irq())
 			tick_nohz_irq_exit();
 	}
+
+	/* need to exit nohz idle if there's a softirq */
+	if (in_serving_softirq() || local_softirq_pending())
+		tick_nohz_idle_exit();
 #endif
 }
 
@@ -416,10 +420,11 @@ static inline void __irq_exit_rcu(void)
 #endif
 	account_hardirq_exit(current);
 	preempt_count_sub(HARDIRQ_OFFSET);
-	if (!in_interrupt() && local_softirq_pending())
-		invoke_softirq();
 
+	/* must call before invoke_softirq */
 	tick_irq_exit();
+	if (!in_interrupt() && local_softirq_pending())
+		invoke_softirq();
 }
 
 /**
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-29  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-28  3:47 [PATCH V1] nohz: exit nohz idle before invoking softirq chenshiyan
2020-12-28 13:28 ` Frederic Weisbecker
2020-12-29  8:39 ` [nohz] 7dbadb2bd2: WARNING:at_kernel/time/tick-sched.c:#tick_nohz_idle_exit kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox