From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DC9C433E0 for ; Mon, 28 Dec 2020 15:27:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2D522475 for ; Mon, 28 Dec 2020 15:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392578AbgL1P1L (ORCPT ); Mon, 28 Dec 2020 10:27:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:34618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504228AbgL1PZ6 (ORCPT ); Mon, 28 Dec 2020 10:25:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D6E5A22472; Mon, 28 Dec 2020 15:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609169117; bh=R4iMJC11Whx65fQ+/OHxhLFq9u6boBvRzAZlsJBOZQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SBmAFpC/eM9LibG1FggIqdnIA+pvCwQExPTtTRBW7qv4vpNhsN8tPbSFmpAwSTYbr TxWwYpQFoCd0DRYck3dDRgrGU1qqQYXzaQFvH9A2kCXzCqGgesCA23IilSMZhW2emi ijbOgb2DRBRVdTk45ddiBBptS6+ngnkMlJ9zf7swif3M6eKbNTPRjWEFDdOy42kGQT VmYDKmC+W7+nTnkem9kN+Io+cTx/O7PEDGOIDU8KA5bBb5Zm6eVnX3M3Ki+VQL5ABj qXD9I6xSHi3w0NaVoP53CrbTtT6bOtf7hT7Af1QgwOqfj3andDwfInan4EtoCua0Mj OvzCHr66AlhYg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 6F048411E9; Mon, 28 Dec 2020 12:25:32 -0300 (-03) Date: Mon, 28 Dec 2020 12:25:32 -0300 From: Arnaldo Carvalho de Melo To: Hans-Peter Nilsson Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Ian Rogers Subject: Re: [PATCH] perf record: Tweak "Lowering..." warning in record_opts__config_freq Message-ID: <20201228152532.GE521329@kernel.org> References: <20201228031908.B049B203B5@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201228031908.B049B203B5@pchp3.se.axis.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 28, 2020 at 04:19:08AM +0100, Hans-Peter Nilsson escreveu: > That is, instead of "Lowering default frequency rate to " say > "Lowering default frequency rate from to ", specifying > the overridden default frequency , so you don't have to grep > through the source to "remember" that was e.g. 4000. Thanks, applied. - Arnaldo > Signed-off-by: Hans-Peter Nilsson > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Adrian Hunter > Cc: Kan Liang > Cc: Ian Rogers > --- > tools/perf/util/record.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/record.c b/tools/perf/util/record.c > index 07e4b96a6625..3b38e7be10da 100644 > --- a/tools/perf/util/record.c > +++ b/tools/perf/util/record.c > @@ -202,10 +202,10 @@ static int record_opts__config_freq(struct record_opts *opts) > * Default frequency is over current maximum. > */ > if (max_rate < opts->freq) { > - pr_warning("Lowering default frequency rate to %u.\n" > + pr_warning("Lowering default frequency rate from %u to %u.\n" > "Please consider tweaking " > "/proc/sys/kernel/perf_event_max_sample_rate.\n", > - max_rate); > + opts->freq, max_rate); > opts->freq = max_rate; > } > > -- > 2.11.0 > > brgds, H-P -- - Arnaldo