Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node

Krzysztof Kozlowski
2020-12-29T16:13:21Z

On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote:
> On Tue, Dec 29, 2020 at 6:15 AM <peng.fan@nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to RM, there is a spba bus inside aips3 and aips1, add it.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362 +++++++++++-----------
> > 1 file changed, 189 insertions(+), 173 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index c824f2615fe8..91f85b8cee9a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -269,117 +269,125 @@ aips1: bus@30000000 {
> > #size-cells = <1>;
> > ranges = <0x30000000 0x30000000 0x400000>;
> >
> > - sai1: sai@30010000 {
> > - #sound-dai-cells = <0>;
> > - compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai";
> > - reg = <0x30010000 0x10000>;
> > - interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clk IMX8MM_CLK_SAI1_IPG>,
> > - <&clk IMX8MM_CLK_SAI1_ROOT>,
> > - <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>;
> > - clock-names = "bus", "mclk1", "mclk2", "mclk3";
> > - dmas = <&sdma2 0 2 0>, <&sdma2 1 2 0>;
> > - dma-names = "rx", "tx";
> > - status = "disabled";
> > - };
> > + bus@30000000 {
>
> There is already a bus@30000000 (aips1), and I think the system
> doesn't like it when there are multiple busses with the same name.
>
> There was some discussion on fixing the 8mn [1], but it doesn't look
> like it went anywhere.
>
> I am guessing the Mini will need something similar to the nano.
>
> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com/

Several replies from S.j. Wang are missing from LKML (and maybe
patchwork?) but we reached a conclusion:
https://lore.kernel.org/linux-arm-kernel/20201208090601.GA8347@kozik-lap/

Either you do some remapping of address space or just rename the "bus"
nodes (e.g. generic bus-1 or a specific spba-bus).

Best regards,
Krzysztof