From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 4/6] block: set .bi_max_vecs as actual allocated vector number
Date: Wed, 30 Dec 2020 08:32:53 +0800 [thread overview]
Message-ID: <20201230003255.3450874-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20201230003255.3450874-1-ming.lei@redhat.com>
bvec_alloc() may allocate more bio vectors than requested, so set .bi_max_vecs as
actual allocated vector number, instead of the requested number. This way can help
fs build bigger bio because new bio often won't be allocated until the current one
becomes full.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/bio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index 3991a5aab1bc..e567feb380b6 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -502,12 +502,13 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs,
goto err_free;
bio->bi_flags |= idx << BVEC_POOL_OFFSET;
+ bio->bi_max_vecs = bvec_nr_vecs(idx);
} else if (nr_iovecs) {
bvl = bio->bi_inline_vecs;
+ bio->bi_max_vecs = inline_vecs;
}
bio->bi_pool = bs;
- bio->bi_max_vecs = nr_iovecs;
bio->bi_io_vec = bvl;
return bio;
--
2.28.0
next prev parent reply other threads:[~2020-12-30 0:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 0:32 [PATCH 0/6] block: improvement on bioset & bvec allocation Ming Lei
2020-12-30 0:32 ` [PATCH 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-04 8:54 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-04 18:13 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Ming Lei
2021-01-04 8:55 ` Christoph Hellwig
2020-12-30 0:32 ` Ming Lei [this message]
2021-01-04 8:55 ` [PATCH 4/6] block: set .bi_max_vecs as actual allocated vector number Christoph Hellwig
2020-12-30 0:32 ` [PATCH 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-04 8:56 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei
2021-01-04 8:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230003255.3450874-5-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox