From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385F8C433DB for ; Wed, 30 Dec 2020 22:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F31B7207A1 for ; Wed, 30 Dec 2020 22:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgL3WBW (ORCPT ); Wed, 30 Dec 2020 17:01:22 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:59617 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgL3WBW (ORCPT ); Wed, 30 Dec 2020 17:01:22 -0500 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 93C3420000A; Wed, 30 Dec 2020 22:00:39 +0000 (UTC) Date: Wed, 30 Dec 2020 23:00:38 +0100 From: Alexandre Belloni To: Nathan Chancellor Cc: Nicolas Pitre , Arnd Bergmann , Nick Desaulniers , Boris Brezillon , Arnd Bergmann , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: re-fix __maybe_unused attribute Message-ID: <20201230220038.GC110311@piout.net> References: <20201230154304.598900-1-arnd@kernel.org> <20201230214053.GB110311@piout.net> <20201230214321.GA1961980@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230214321.GA1961980@ubuntu-m3-large-x86> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/12/2020 14:43:21-0700, Nathan Chancellor wrote: > On Wed, Dec 30, 2020 at 10:40:53PM +0100, Alexandre Belloni wrote: > > On 30/12/2020 16:23:56-0500, Nicolas Pitre wrote: > > > On Wed, 30 Dec 2020, Arnd Bergmann wrote: > > > > > > > From: Arnd Bergmann > > > > > > > > clang warns because the added __maybe_unused attribute is in > > > > the wrong place: > > > > > > > > drivers/i3c/master/mipi-i3c-hci/core.c:780:21: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] > > > > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = { > > > > ^ > > > > include/linux/compiler_attributes.h:267:56: note: expanded > > > > > > > > Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused variable warning") > > > > Signed-off-by: Arnd Bergmann > > > > > > Acked-by: Nicolas Pitre > > > > > > This might be the 3rd patch from 3 different people fixing the same > > > thing. Looks like I3C maintainer is on vacation. Please feel free to > > > send this trivial fix upstream some other way. > > > > > > > Isn't it already upstream? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95393f3e07ab53855b91881692a4a5b52dcdc03c > > This patch is fixing that one, the attribute was added between the > struct type, causing a new warning for clang. > Ah yes, even after reading that 3 times, I got it wrong. > I sent a fix for this earlier too, I do not care which one goes in as > long as one does so: > > Reviewed-by: Nathan Chancellor > I was going to review and apply yours now that I have access to the i3c repo. I must admit I didn't have a look at i3c patches until now and the holiday season is not helping. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com