From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E997CC433E0 for ; Mon, 4 Jan 2021 08:57:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8DAB2087E for ; Mon, 4 Jan 2021 08:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbhADI5R (ORCPT ); Mon, 4 Jan 2021 03:57:17 -0500 Received: from verein.lst.de ([213.95.11.211]:56927 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbhADI5Q (ORCPT ); Mon, 4 Jan 2021 03:57:16 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id AE32E6736F; Mon, 4 Jan 2021 09:56:34 +0100 (CET) Date: Mon, 4 Jan 2021 09:56:34 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] block: move three bvec helpers declaration into private helper Message-ID: <20210104085634.GD28949@lst.de> References: <20201230003255.3450874-1-ming.lei@redhat.com> <20201230003255.3450874-6-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230003255.3450874-6-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *); > +extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int); > +extern unsigned int bvec_nr_vecs(unsigned short idx); Please drop the externs while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig