From: Vinod Koul <vkoul@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: fix gpi undefined behavior
Date: Mon, 4 Jan 2021 18:08:48 +0530 [thread overview]
Message-ID: <20210104123848.GG120946@vkoul-mobl> (raw)
In-Reply-To: <20210103135738.3741123-1-arnd@kernel.org>
On 03-01-21, 14:57, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc points out an incorrect error handling loop:
>
> drivers/dma/qcom/gpi.c: In function 'gpi_ch_init':
> drivers/dma/qcom/gpi.c:1254:15: error: iteration 2 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
> 1254 | struct gpii *gpii = gchan->gpii;
> | ^~~~
> drivers/dma/qcom/gpi.c:1951:2: note: within this loop
> 1951 | for (i = i - 1; i >= 0; i++) {
> | ^~~
>
> Change the loop to correctly walk backwards through the
> initialized fields rather than off into the woods.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-01-04 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 13:57 [PATCH] dmaengine: qcom: fix gpi undefined behavior Arnd Bergmann
2021-01-04 12:38 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104123848.GG120946@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox