From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CF2C433E6 for ; Mon, 4 Jan 2021 18:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C3932076D for ; Mon, 4 Jan 2021 18:41:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727743AbhADSlh (ORCPT ); Mon, 4 Jan 2021 13:41:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727091AbhADSlg (ORCPT ); Mon, 4 Jan 2021 13:41:36 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B670C061793 for ; Mon, 4 Jan 2021 10:40:56 -0800 (PST) Received: from zn.tnic (p200300ec2f086c00477cccdca46ad35a.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:6c00:477c:ccdc:a46a:d35a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A03861EC0300; Mon, 4 Jan 2021 19:40:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1609785654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1IrJEPqy47tJ8tj13J9znmWrNyKbcOQeWIwH/pLaAy0=; b=b98vkCW4lphpmXn7AAy2SipqYXyWBfOrvGLU2niEkEwW7CcI8W+pW0TbGiPX8dcZcBH/D5 52Ogk5MxFviRL0Fz8YnWa1TmZDkQZh/En3jO5yd/pgPHiLVR7XlpnWkx0i1fWgDG+wbtlN kWOpuUzO4C+DDb4ooWXd0+hsULCQOdM= Date: Mon, 4 Jan 2021 19:40:51 +0100 From: Borislav Petkov To: Masami Hiramatsu Cc: Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, "Naveen N . Rao" , Anil S Keshavamurthy , David Miller , x86@kernel.org Subject: Re: [PATCH -tip v2] x86/kprobes: Do not decode opcode in resume_execution() Message-ID: <20210104184051.GG32151@zn.tnic> References: <20201218214432.b025656de019c64a8f4e2da5@kernel.org> <160830072561.349576.3014979564448023213.stgit@devnote2> <20201231160923.GB4504@zn.tnic> <20210104124558.7c89fb6fa305507c098f0d85@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210104124558.7c89fb6fa305507c098f0d85@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2021 at 12:45:58PM +0900, Masami Hiramatsu wrote: > Hrm, I meant setting the flags used in the resume_execution() afterwards. > Since the instruction itself (not only opcode but also oprands) was > also analyzed in other places, so I like the set_resume_flags() for it. Your call but I still think that set_resume_flags() is misleading. You even have in the comment above it: "Analyze the opcode and set resume flags." so it is doing some insn analysis and setting flags as a result. But I won't insist - you're the one who's going to be staring at that code. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette