From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C89C433E6 for ; Mon, 4 Jan 2021 21:31:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B06E621D93 for ; Mon, 4 Jan 2021 21:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbhADVbX (ORCPT ); Mon, 4 Jan 2021 16:31:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:40582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbhADVbW (ORCPT ); Mon, 4 Jan 2021 16:31:22 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A87221D93; Mon, 4 Jan 2021 21:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609795832; bh=CZGZG34DbWC5gsN2Vh0sggMMgMDglmyHaa/JpxJ4QFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aXBgzn1Wvhb9UmpKOLOwAJ0JpwUniCSSzHISpcQhcn4va9lsmoBys8Aw/jE3Zpfat wYXcAai72ledErLlh79FgoSkGRmAziO1In6N5hXw5ad12tkP2sZNwiKEmYQH7dOL05 0J/JGc+oTex1kdN52OS0kSAuGpvSV2VS6MhJKuyTNgEvLHkTLg7I+H3w/Oa4LKoKhq A7AnvYvFhcq2xpLL8XAAtlLHmO7sj+t7KWkKtjLoK2DLhmmMoHD/dUo5iMRYbblRpZ ZJZ1avuw6bisMcp/lVX2KfTCQBBpkk5IJrwIDcUfY8MzWEMPCCJlymy9whFMgJp/Fl UUAQUyHoN1rVw== Date: Mon, 4 Jan 2021 21:30:05 +0000 From: Mark Brown To: "Lad, Prabhakar" Cc: Geert Uytterhoeven , Pavel Machek , Lad Prabhakar , Jiri Kosina , Sergei Shtylyov , linux-spi , Linux Kernel Mailing List , Linux-Renesas , Chris Brandt Subject: Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery Message-ID: <20210104213005.GK5645@sirena.org.uk> References: <20201230145708.28544-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201230145708.28544-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vk/v8fjDPiDepTtA" Content-Disposition: inline In-Reply-To: X-Cookie: Stupidity is its own reward. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vk/v8fjDPiDepTtA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 09:25:17PM +0000, Lad, Prabhakar wrote: > > > .name = "rpc-if-spi", > > > - .pm = DEV_PM_OPS, > > > + .pm = &rpcif_spi_pm_ops, > > You're aware rpcif_spi_pm_ops is now always referenced and thus emitted, > > increasing kernel size by 92 bytes if CONFIG_PM_SLEEP=n? > > This may matter for RZ/A SoCs running from internal SRAM. > Hmm didn't realise this would be an issue on RZ/A. > Mark, could you please drop this patch from your branch. Please send an incremental patch with an appropriate changelog. --vk/v8fjDPiDepTtA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/ziNwACgkQJNaLcl1U h9AiDQf+NWLL5kYwXv2qsnNIGJfyYBlpbr2ha6Uhdk6t8uVWUtRMGhrK2HrEN+qt bh7DXtD92HVLW/88Mzq7tW8IzVjpM63dA3V7DlY4PO+iRjHFXsHcjR7OuhMTDxti 2Bra/G29guzIP2J703fbYq059L/uxAbhf2wMoiVvYSdf8V6O8dZrR4UMzdTLiHsF 98dR+Jlp9hX9IWKfnBqqzSe6g0Nina62lAEzXyAJaaX3sBa2lTUSC4jlX5KVyo5z RLMqlxHrX6sOGrio6SMnYVlQ9RHUVLFn0Y6nojxanRG+blxRqCN68JwWNASLmZT3 F5P9WDjT2FKJCc1ZhxrBW9vdzT2kZA== =tYtr -----END PGP SIGNATURE----- --vk/v8fjDPiDepTtA--