From: Mark Brown <broonie@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Marc Zyngier <maz@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Sudeep Holla <sudeep.holla@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] arm64: Add support for SMCCC TRNG entropy source
Date: Tue, 5 Jan 2021 17:00:14 +0000 [thread overview]
Message-ID: <20210105170014.GG4487@sirena.org.uk> (raw)
In-Reply-To: <20210105163652.23646-5-andre.przywara@arm.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Tue, Jan 05, 2021 at 04:36:51PM +0000, Andre Przywara wrote:
> @@ -77,10 +117,20 @@ arch_get_random_seed_long_early(unsigned long *v)
> {
> WARN_ON(system_state != SYSTEM_BOOTING);
>
> - if (!__early_cpu_has_rndr())
> - return false;
> + if (__early_cpu_has_rndr())
> + return __arm64_rndr(v);
> +
> + if (smccc_trng_available) {
> + struct arm_smccc_res res;
This still seems to be preferring RNDR over SMCCC for the early seed
unless I'm misreading the diff?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-05 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 16:36 [PATCH v5 0/5] ARM: arm64: Add SMCCC TRNG entropy service Andre Przywara
2021-01-05 16:36 ` [PATCH v5 1/5] firmware: smccc: Add SMCCC TRNG function call IDs Andre Przywara
2021-01-05 16:36 ` [PATCH v5 2/5] firmware: smccc: Introduce SMCCC TRNG framework Andre Przywara
2021-01-05 16:36 ` [PATCH v5 3/5] ARM: implement support for SMCCC TRNG entropy source Andre Przywara
2021-01-05 16:36 ` [PATCH v5 4/5] arm64: Add " Andre Przywara
2021-01-05 17:00 ` Mark Brown [this message]
2021-01-06 9:54 ` Andre Przywara
2021-01-05 16:36 ` [PATCH v5 5/5] KVM: arm64: implement the TRNG hypervisor call Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105170014.GG4487@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andre.przywara@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox