From: Lee Jones <lee.jones@linaro.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: use resource_size
Date: Wed, 6 Jan 2021 13:53:27 +0000 [thread overview]
Message-ID: <20210106135327.GD1592923@dell> (raw)
In-Reply-To: <20210106131653.32441-1-zhengyongjun3@huawei.com>
Please fix your subject line to match the others in the subsystem.
`git log --oneline -- drivers/<subsystem>` is your friend.
On Wed, 06 Jan 2021, Zheng Yongjun wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
Not sure I can see how this matches to the diff below?
Please could you provide more detail?
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mfd/88pm860x-core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
> index c9bae71f643a..a9e0855b4c66 100644
> --- a/drivers/mfd/88pm860x-core.c
> +++ b/drivers/mfd/88pm860x-core.c
> @@ -916,7 +916,7 @@ static void device_power_init(struct pm860x_chip *chip,
> power_devs[0].platform_data = pdata->power;
> power_devs[0].pdata_size = sizeof(struct pm860x_power_pdata);
> power_devs[0].num_resources = ARRAY_SIZE(battery_resources);
> - power_devs[0].resources = &battery_resources[0],
> + power_devs[0].resources = &battery_resources[0];
> ret = mfd_add_devices(chip->dev, 0, &power_devs[0], 1,
> &battery_resources[0], chip->irq_base, NULL);
> if (ret < 0)
> @@ -925,7 +925,7 @@ static void device_power_init(struct pm860x_chip *chip,
> power_devs[1].platform_data = pdata->power;
> power_devs[1].pdata_size = sizeof(struct pm860x_power_pdata);
> power_devs[1].num_resources = ARRAY_SIZE(charger_resources);
> - power_devs[1].resources = &charger_resources[0],
> + power_devs[1].resources = &charger_resources[0];
> ret = mfd_add_devices(chip->dev, 0, &power_devs[1], 1,
> &charger_resources[0], chip->irq_base, NULL);
> if (ret < 0)
> @@ -942,7 +942,7 @@ static void device_power_init(struct pm860x_chip *chip,
> pdata->chg_desc->charger_regulators =
> &chg_desc_regulator_data[0];
> pdata->chg_desc->num_charger_regulators =
> - ARRAY_SIZE(chg_desc_regulator_data),
> + ARRAY_SIZE(chg_desc_regulator_data);
> power_devs[3].platform_data = pdata->chg_desc;
> power_devs[3].pdata_size = sizeof(*pdata->chg_desc);
> ret = mfd_add_devices(chip->dev, 0, &power_devs[3], 1,
> @@ -958,7 +958,7 @@ static void device_onkey_init(struct pm860x_chip *chip,
> int ret;
>
> onkey_devs[0].num_resources = ARRAY_SIZE(onkey_resources);
> - onkey_devs[0].resources = &onkey_resources[0],
> + onkey_devs[0].resources = &onkey_resources[0];
> ret = mfd_add_devices(chip->dev, 0, &onkey_devs[0],
> ARRAY_SIZE(onkey_devs), &onkey_resources[0],
> chip->irq_base, NULL);
> @@ -972,7 +972,7 @@ static void device_codec_init(struct pm860x_chip *chip,
> int ret;
>
> codec_devs[0].num_resources = ARRAY_SIZE(codec_resources);
> - codec_devs[0].resources = &codec_resources[0],
> + codec_devs[0].resources = &codec_resources[0];
> ret = mfd_add_devices(chip->dev, 0, &codec_devs[0],
> ARRAY_SIZE(codec_devs), &codec_resources[0], 0,
> NULL);
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-01-06 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:16 [PATCH -next] mfd: use resource_size Zheng Yongjun
2021-01-06 13:53 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106135327.GD1592923@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox