From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FD4C433DB for ; Wed, 6 Jan 2021 14:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA5C123125 for ; Wed, 6 Jan 2021 14:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbhAFOuk convert rfc822-to-8bit (ORCPT ); Wed, 6 Jan 2021 09:50:40 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56615 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbhAFOuj (ORCPT ); Wed, 6 Jan 2021 09:50:39 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 388DC60006; Wed, 6 Jan 2021 14:49:55 +0000 (UTC) Date: Wed, 6 Jan 2021 15:49:54 +0100 From: Miquel Raynal To: Zheng Yongjun Cc: , , , Subject: Re: [PATCH -next] mtd: use resource_size Message-ID: <20210106154954.4f85ed76@xps13> In-Reply-To: <20210106131831.301-1-zhengyongjun3@huawei.com> References: <20210106131831.301-1-zhengyongjun3@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Zheng Yongjun wrote on Wed, 6 Jan 2021 21:18:31 +0800: > Use resource_size rather than a verbose computation on > the end and start fields. The commit message and the patch content do not match. > > Signed-off-by: Zheng Yongjun > --- > drivers/mtd/maps/pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c > index 377ef0fc4e3e..ca00d211e73e 100644 > --- a/drivers/mtd/maps/pci.c > +++ b/drivers/mtd/maps/pci.c > @@ -90,8 +90,8 @@ intel_iq80310_init(struct pci_dev *dev, struct map_pci_info *map) > u32 win_base; > > map->map.bankwidth = 1; > - map->map.read = mtd_pci_read8, > - map->map.write = mtd_pci_write8, > + map->map.read = mtd_pci_read8; > + map->map.write = mtd_pci_write8; > > map->map.size = 0x00800000; > map->base = ioremap(pci_resource_start(dev, 0), > @@ -185,8 +185,8 @@ intel_dc21285_init(struct pci_dev *dev, struct map_pci_info *map) > return -ENXIO; > > map->map.bankwidth = 4; > - map->map.read = mtd_pci_read32, > - map->map.write = mtd_pci_write32, > + map->map.read = mtd_pci_read32; > + map->map.write = mtd_pci_write32; > map->map.size = len; > map->base = ioremap(base, len); > Thanks, Miquèl