From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86149C433E9 for ; Wed, 6 Jan 2021 14:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49FB92311C for ; Wed, 6 Jan 2021 14:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbhAFOvc convert rfc822-to-8bit (ORCPT ); Wed, 6 Jan 2021 09:51:32 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:57225 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbhAFOvc (ORCPT ); Wed, 6 Jan 2021 09:51:32 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 068B510000B; Wed, 6 Jan 2021 14:50:48 +0000 (UTC) Date: Wed, 6 Jan 2021 15:50:47 +0100 From: Miquel Raynal To: Zheng Yongjun Cc: , , , Subject: Re: [PATCH -next] mtd: rawnand: marvell: use resource_size Message-ID: <20210106155047.5d39fc42@xps13> In-Reply-To: <20210106131839.371-1-zhengyongjun3@huawei.com> References: <20210106131839.371-1-zhengyongjun3@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Zheng Yongjun wrote on Wed, 6 Jan 2021 21:18:39 +0800: > Use resource_size rather than a verbose computation on > the end and start fields. Same as your previous patch, the description does not match the change. > > Signed-off-by: Zheng Yongjun > --- > drivers/mtd/nand/raw/marvell_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c > index f5ca2002d08e..3e01b11c87f8 100644 > --- a/drivers/mtd/nand/raw/marvell_nand.c > +++ b/drivers/mtd/nand/raw/marvell_nand.c > @@ -2396,7 +2396,7 @@ static int marvell_nfc_setup_interface(struct nand_chip *chip, int chipnr, > * be greater than that to be sure tCCS delay is respected. > */ > nfc_tmg.tWHR = TO_CYCLES(max_t(int, sdr->tWHR_min, sdr->tCCS_min), > - period_ns) - 2, > + period_ns) - 2; > nfc_tmg.tRHW = TO_CYCLES(max_t(int, sdr->tRHW_min, sdr->tCCS_min), > period_ns); > Thanks, Miquèl