From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD52C433DB for ; Wed, 6 Jan 2021 14:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC8922311B for ; Wed, 6 Jan 2021 14:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbhAFOwT convert rfc822-to-8bit (ORCPT ); Wed, 6 Jan 2021 09:52:19 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:44989 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbhAFOwS (ORCPT ); Wed, 6 Jan 2021 09:52:18 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 5739E1C0002; Wed, 6 Jan 2021 14:51:35 +0000 (UTC) Date: Wed, 6 Jan 2021 15:51:33 +0100 From: Miquel Raynal To: Zheng Yongjun Cc: , , , Subject: Re: [PATCH -next] mtd: st_spi_fsm: use resource_size Message-ID: <20210106155133.7f901871@xps13> In-Reply-To: <20210106131847.443-1-zhengyongjun3@huawei.com> References: <20210106131847.443-1-zhengyongjun3@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Zheng Yongjun wrote on Wed, 6 Jan 2021 21:18:47 +0800: > Use resource_size rather than a verbose computation on > the end and start fields. > > Signed-off-by: Zheng Yongjun > --- > drivers/mtd/devices/st_spi_fsm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c > index 1888523d9745..983999c020d6 100644 > --- a/drivers/mtd/devices/st_spi_fsm.c > +++ b/drivers/mtd/devices/st_spi_fsm.c > @@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd, > BUG_ON(bytes != 1 && bytes != 2); > > seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) | > - SEQ_OPC_OPCODE(cmd)), > + SEQ_OPC_OPCODE(cmd)); > > stfsm_load_seq(fsm, seq); > Same remark again, description and actual change do not match. Thanks, Miquèl