Re: [PATCH 4/4] Input: omap4-keypad - simplify probe with devm

Tony Lindgren
2021-01-08T07:26:26Z

* Sebastian Reichel <sre@kernel.org> [210106 13:44]:
> On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote:
> > - struct resource *res;
> >
> > dev_pm_clear_wake_irq(&pdev->dev);
> > -
> > - free_irq(keypad_data->irq, keypad_data);
> > -
> > pm_runtime_dont_use_autosuspend(&pdev->dev);
> > pm_runtime_disable(&pdev->dev);
> > -
> > input_unregister_device(keypad_data->input);
>
> not needed:
>
> * devm_input_allocate_device - allocate managed input device
> * @dev: device owning the input device being created
> *
> * Returns prepared struct input_dev or %NULL.
> *
> * Managed input devices do not need to be explicitly unregistered or
> * freed as it will be done automatically when owner device unbinds from
> * its driver (or binding fails). [...]

OK thanks will drop and fix up the reported autobuild warnings
and repost. Looks like also the OMAP4_KEYPAD_AUTOIDLE_MS value
of 50 is too long, I recently changed it from 30 but now have
seen few stuck last pressed keys.

Regards,

Tony