From: Borislav Petkov <bp@alien8.de>
To: Dave Jiang <dave.jiang@intel.com>
Cc: x86@kernel.org, kernel test robot <lkp@intel.com>,
Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: fix movdir64b() sparse warning
Date: Thu, 7 Jan 2021 08:55:33 +0100 [thread overview]
Message-ID: <20210107075533.GD14697@zn.tnic> (raw)
In-Reply-To: <160997278817.3976343.969979053457914470.stgit@djiang5-desk3.ch.intel.com>
On Wed, Jan 06, 2021 at 03:40:25PM -0700, Dave Jiang wrote:
> Subject: Re: [PATCH v2] x86: fix movdir64b() sparse warning
There are a lot of times I don't agree with checkpatch but this time I do:
WARNING: A patch subject line should describe the change not the tool that found it
#2:
Subject: [PATCH v2] x86: fix movdir64b() sparse warning
Pls fix your other patch subject too.
> Add missing __iomem annotation to address sparse warning. Caller is expected
> to pass an __iomem annotated pointer to this function. The current usages
> send a 64bytes command descriptor to an MMIO location (portal) on a
> device for consumption. When future usages for MOVDIR64B instruction show
> up in kernel for memory to memory operation is needed, we can revisit.
Who's "we"?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-01-07 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 22:40 [PATCH v2] x86: fix movdir64b() sparse warning Dave Jiang
2021-01-07 7:55 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107075533.GD14697@zn.tnic \
--to=bp@alien8.de \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox