From: Herbert Xu <herbert@gondor.apana.org.au>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Tero Kristo <t-kristo@ti.com>, Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: omap-sham - Fix link error without crypto-engine
Date: Fri, 8 Jan 2021 15:43:07 +1100 [thread overview]
Message-ID: <20210108044307.GD12339@gondor.apana.org.au> (raw)
In-Reply-To: <20210103140318.3902174-1-arnd@kernel.org>
On Sun, Jan 03, 2021 at 03:03:04PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver was converted to use the crypto engine helper
> but is missing the corresponding Kconfig statement to ensure
> it is available:
>
> arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_probe':
> omap-sham.c:(.text+0x374): undefined reference to `crypto_engine_alloc_init'
> arm-linux-gnueabi-ld: omap-sham.c:(.text+0x384): undefined reference to `crypto_engine_start'
> arm-linux-gnueabi-ld: omap-sham.c:(.text+0x510): undefined reference to `crypto_engine_exit'
> arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_finish_req':
> omap-sham.c:(.text+0x98c): undefined reference to `crypto_finalize_hash_request'
> arm-linux-gnueabi-ld: omap-sham.c:(.text+0x9a0): undefined reference to `crypto_transfer_hash_request_to_engine'
> arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_update':
> omap-sham.c:(.text+0xf24): undefined reference to `crypto_transfer_hash_request_to_engine'
> arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_final':
> omap-sham.c:(.text+0x1020): undefined reference to `crypto_transfer_hash_request_to_engine'
>
> Fixes: 133c3d434d91 ("crypto: omap-sham - convert to use crypto engine")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-01-08 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 14:03 [PATCH] crypto: omap-sham - Fix link error without crypto-engine Arnd Bergmann
2021-01-08 4:43 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108044307.GD12339@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox