* [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
@ 2020-12-15 21:26 Michael Walle
2021-01-07 6:40 ` Shawn Guo
2021-01-10 12:00 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Michael Walle @ 2020-12-15 21:26 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Sudhanshu Gupta, Bhaskar Upadhaya,
Rai Harninder, Michael Walle
The offset of the reset request register is 0, the absolute address is
0x1e60000. Boards without PSCI support will fail to perform a reset:
[ 26.734700] reboot: Restarting system
[ 27.743259] Unable to restart system
[ 27.746845] Reboot failed -- System halted
Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 045739dbcb17..0a5923e96d7f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -102,7 +102,7 @@
reboot {
compatible ="syscon-reboot";
regmap = <&rst>;
- offset = <0xb0>;
+ offset = <0>;
mask = <0x02>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
2020-12-15 21:26 [PATCH] arm64: dts: ls1028a: fix the offset of the reset register Michael Walle
@ 2021-01-07 6:40 ` Shawn Guo
2021-01-07 6:43 ` Shawn Guo
2021-01-07 7:53 ` Michael Walle
2021-01-10 12:00 ` Shawn Guo
1 sibling, 2 replies; 5+ messages in thread
From: Shawn Guo @ 2021-01-07 6:40 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang,
Sudhanshu Gupta, Bhaskar Upadhaya, Rai Harninder
On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> The offset of the reset request register is 0, the absolute address is
> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>
> [ 26.734700] reboot: Restarting system
> [ 27.743259] Unable to restart system
> [ 27.746845] Reboot failed -- System halted
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4
("arm64: dts: ls1028a: fix reboot node") in the first place?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 045739dbcb17..0a5923e96d7f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -102,7 +102,7 @@
> reboot {
> compatible ="syscon-reboot";
> regmap = <&rst>;
> - offset = <0xb0>;
> + offset = <0>;
> mask = <0x02>;
> };
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
2021-01-07 6:40 ` Shawn Guo
@ 2021-01-07 6:43 ` Shawn Guo
2021-01-07 7:53 ` Michael Walle
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2021-01-07 6:43 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, Linux Kernel Mailing List, Li Yang,
Sudhanshu Gupta, Bhaskar Upadhaya, Rai Harninder
On Thu, Jan 7, 2021 at 2:40 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> > The offset of the reset request register is 0, the absolute address is
> > 0x1e60000. Boards without PSCI support will fail to perform a reset:
> >
> > [ 26.734700] reboot: Restarting system
> > [ 27.743259] Unable to restart system
> > [ 27.746845] Reboot failed -- System halted
> >
> > Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> > Signed-off-by: Michael Walle <michael@walle.cc>
>
> Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4
How did you *not*, I meant.
Shawn
> ("arm64: dts: ls1028a: fix reboot node") in the first place?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
2021-01-07 6:40 ` Shawn Guo
2021-01-07 6:43 ` Shawn Guo
@ 2021-01-07 7:53 ` Michael Walle
1 sibling, 0 replies; 5+ messages in thread
From: Michael Walle @ 2021-01-07 7:53 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang,
Sudhanshu Gupta, Bhaskar Upadhaya, Rai Harninder
Hi Shawn,
Am 2021-01-07 07:40, schrieb Shawn Guo:
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
>> The offset of the reset request register is 0, the absolute address is
>> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>>
>> [ 26.734700] reboot: Restarting system
>> [ 27.743259] Unable to restart system
>> [ 27.746845] Reboot failed -- System halted
>>
>> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> Out of curiosity, how did you get it fixed with your commit
> 3f0fb37b22b4
> ("arm64: dts: ls1028a: fix reboot node") in the first place?
I simply must have missed it. There is also a fallback reset method
via the watchdog in the chain, which kicks in if this wasn't successful.
So if you test it, it is easy to think its working although its not.
-michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
2020-12-15 21:26 [PATCH] arm64: dts: ls1028a: fix the offset of the reset register Michael Walle
2021-01-07 6:40 ` Shawn Guo
@ 2021-01-10 12:00 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2021-01-10 12:00 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang,
Sudhanshu Gupta, Bhaskar Upadhaya, Rai Harninder
On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
> The offset of the reset request register is 0, the absolute address is
> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>
> [ 26.734700] reboot: Restarting system
> [ 27.743259] Unable to restart system
> [ 27.746845] Reboot failed -- System halted
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-10 12:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 21:26 [PATCH] arm64: dts: ls1028a: fix the offset of the reset register Michael Walle
2021-01-07 6:40 ` Shawn Guo
2021-01-07 6:43 ` Shawn Guo
2021-01-07 7:53 ` Michael Walle
2021-01-10 12:00 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox