From: kernel test robot <lkp@intel.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
Luben Tuikov <luben.tuikov@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1855:42: warning: Uninitialized variable: fw_ver
Date: Sun, 10 Jan 2021 13:27:31 +0800 [thread overview]
Message-ID: <202101101327.Ajd5OjSM-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2ff90100ace886895e4fbb2850b8d5e49d931ed6
commit: 57430471e2fa60a412e220fa3014567e792aaa6f drm/amdgpu: Add support for USBC PD FW download
date: 10 months ago
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"cppcheck warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1855:42: warning: Uninitialized variable: fw_ver [uninitvar]
return snprintf(buf, PAGE_SIZE, "%xn", fw_ver);
^
vim +1855 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
1836
1837 static ssize_t psp_usbc_pd_fw_sysfs_read(struct device *dev,
1838 struct device_attribute *attr,
1839 char *buf)
1840 {
1841 struct drm_device *ddev = dev_get_drvdata(dev);
1842 struct amdgpu_device *adev = ddev->dev_private;
1843 uint32_t fw_ver;
1844 int ret;
1845
1846 mutex_lock(&adev->psp.mutex);
1847 ret = psp_read_usbc_pd_fw(&adev->psp, &fw_ver);
1848 mutex_unlock(&adev->psp.mutex);
1849
1850 if (ret) {
1851 DRM_ERROR("Failed to read USBC PD FW, err = %d", ret);
1852 return ret;
1853 }
1854
> 1855 return snprintf(buf, PAGE_SIZE, "%x\n", fw_ver);
1856 }
1857
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2021-01-10 5:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 5:27 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-05 22:18 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1855:42: warning: Uninitialized variable: fw_ver kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101101327.Ajd5OjSM-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexander.deucher@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox