From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F32CC433E0 for ; Mon, 11 Jan 2021 01:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D11A82253A for ; Mon, 11 Jan 2021 01:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbhAKBl6 (ORCPT ); Sun, 10 Jan 2021 20:41:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:56520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbhAKBl6 (ORCPT ); Sun, 10 Jan 2021 20:41:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A904C2251F; Mon, 11 Jan 2021 01:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610329277; bh=kAHJ6uYNEobDjgaOJm9STHnuZlZSHgvmiRlXkbgjj0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mi+PvlUFJ1EAsci7yG/kklI5D2/5oSgH8smxcNU/jYKKznp2K6ZteX/SfucH8EvPl JulPWAJ2Aync5TlJiQcSzFeQVZXYqvYFTw9F7tBtqpvnd9nvvPmI64UqqSoZbN4w0d 6DQ9JdwkaPiSD2qqaY76VwifqcvMY7+/VoVP+ESWTCjV5fYVKC2BsbaGKdS3GupzX1 Sl/wnATYwjtAwt25jcNVz220AXGGESYA2CZ+OewUTXeP1gFRCk5+rPDZTKJ4Es+OYF 2BDO3QR7KHRJxtAHmqCDN/uFdOLInSed/ak/IgN3SDI8zXvBBHmQBaqN3yTDM1wGdd FYDsk2WoFszKg== Date: Mon, 11 Jan 2021 09:41:11 +0800 From: Shawn Guo To: Arnd Bergmann Cc: Michael Turquette , Stephen Boyd , Sascha Hauer , Dong Aisheng , Sebastian Andrzej Siewior , Arnd Bergmann , Anders Roxell , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Peng Fan , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk Message-ID: <20210111014110.GW28365@dragon> References: <20201230155244.981757-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230155244.981757-1-arnd@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 04:52:25PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > A previous patch introduced a harmless randconfig warning: > > WARNING: unmet direct dependencies detected for MXC_CLK_SCU > Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y] > Selected by [m]: > - CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y] > > Since the symbol is now hidden and only selected by other symbols, > just remove the dependencies and require the other drivers to > get it right. > > Fixes: 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break") > Reported-by: Anders Roxell > Signed-off-by: Arnd Bergmann Looks good to me. Stephen, I assume that you will pick it up as a material for 5.11-rc. Shawn