From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095AAC433DB for ; Mon, 11 Jan 2021 11:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AECE9224B1 for ; Mon, 11 Jan 2021 11:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729535AbhAKLN5 (ORCPT ); Mon, 11 Jan 2021 06:13:57 -0500 Received: from mga06.intel.com ([134.134.136.31]:52483 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727143AbhAKLN4 (ORCPT ); Mon, 11 Jan 2021 06:13:56 -0500 IronPort-SDR: oc8yQTos5UGbXtQRsbLfnmW/D5NMm6buzMPB1Bc1BR8h8nGvKvBknQNcRqoATcrMZ1uQlSNGaD L51U24Os/CNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9860"; a="239384620" X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="239384620" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 03:13:10 -0800 IronPort-SDR: QttBTfr48Xyi6MyBpwAiEQudiv/a2xDxer/36n8OAkM1vYyTsJHuEg2qeUTwTUwYM7wA0B57Dx hWeE/gc4+ypA== X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="464131003" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 03:13:08 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kyv9F-00A8Xk-5t; Mon, 11 Jan 2021 13:14:09 +0200 Date: Mon, 11 Jan 2021 13:14:09 +0200 From: Andy Shevchenko To: Richard Fitzgerald Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Shuah Khan , patches@opensource.cirrus.com, Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Rasmus Villemoes Subject: Re: [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width > 1 Message-ID: <20210111111409.GW4077@smile.fi.intel.com> References: <20201217180057.23786-1-rf@opensource.cirrus.com> <395b37b8-d9b2-1825-8e57-9e1b74aa7502@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <395b37b8-d9b2-1825-8e57-9e1b74aa7502@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 10:43:17AM +0000, Richard Fitzgerald wrote: > On 11/01/2021 10:39, Richard Fitzgerald wrote: > > On 11/01/2021 10:36, Andy Shevchenko wrote: > > > On Mon, Jan 11, 2021 at 12:28 PM Petr Mladek wrote: > > > > > > > > Sigh, I have just realized that Andy and Rasmus, the other > > > > vsprintf maintainers and reviewers, were not in CC. > > > > I am sorry for not noticing this earlier. > > > > > > > > The patchset is ready for 5.12 from my POV. > > > > > > Thanks, Petr! > > > > > > I have one question, do we have a test case for that? If not, I prefer > > > defer until a test case will be provided. > > > > > > > See patch 3, numbers_prefix_overflow() > > Sorry, I missed you off the original mailing so you won't have > seen the other patches. > Patch 3 with the test cases is here: > https://lore.kernel.org/lkml/X%2FwnoJLEt0zQskDU@alley/T/#mf2ffba20126e438bea7af171bc78fdbebdb40027 Good, you did it! Couple of remarks: - free resources in the same function where you allocated them - use post increment where it doesn't matter (like total_test) -- With Best Regards, Andy Shevchenko