Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

On Mon, Jan 11, 2021 at 09:21:11AM -0800, Florian Fainelli wrote:
> On 1/11/21 9:05 AM, Mark Brown wrote:

> > Honestly for super trivial stuff like this I'm not sure it's a useful
> > use of anyone's time to police this sort of stuff aggressively, it's
> > after the prefixes that matter so I saw it easily and I'm having a hard
> > time caring that it happens to be done as a prefix rather than saying
> > style somewhere else in the subject.

> That sounds fair, however it does look like people who submit trivial
> patches are typically the ones that also tend not to follow prior
> commits to the same file, and given the patch is trivial, enforcing a
> consistent subject sort of offsets the less amount of time spent in
> reviewing the patch.

Yeah, I do tend to moan if the commonly used prefixes aren't there but
I tend not to worry about anything after that.

> > I will generally hold off for longer with these trivial patches on
> > things where I expect to see some review but that's felt a bit patchy
> > with the Broadcom drivers.

> OK, we will try to be more reactive then, Kamal is in GMT-0500 and I am
> GMT-0800 so it make take a bit of time for us to get to our review backlog.

To be clear it's more that if there's generally a review of any patch
within say a week or a few days or something then I'll hold off until it
materializes but if it's likely to time out then I'll tend to just go
ahead immediately.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]