From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Timur Tabi <timur@tabi.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Roman Fietze <roman.fietze@magna.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses
Date: Mon, 11 Jan 2021 17:30:09 -0800 [thread overview]
Message-ID: <20210111173009.fe2383539e5ca2c23b135262@linux-foundation.org> (raw)
In-Reply-To: <X/wkMMiPPBAJb9+A@alley>
On Mon, 11 Jan 2021 11:10:56 +0100 Petr Mladek <pmladek@suse.com> wrote:
> Adding Kees into CC because it is security related.
> Adding Andrew into CC because he usually takes patches for hexdump.
>
> On Wed 2021-01-06 15:35:47, Timur Tabi wrote:
> > Hashed addresses are useless in hexdumps unless you're comparing
> > with other hashed addresses, which is unlikely. However, there's
> > no need to break existing code, so introduce a new prefix type
> > that prints unhashed addresses.
> >
> > Signed-off-by: Timur Tabi <timur@tabi.org>
> > Cc: Roman Fietze <roman.fietze@magna.com>
>
> I agree that there should be way to print the real address.
>
> And it is sane to add a new mode so that the current
> users stay hashed.
>
I doubt if Kees (or I or anyone else) can review this change because
there are no callers which actually use the new DUMP_PREFIX_UNHASHED.
Is it intended that some other places in the kernel be changed to use
this? If so, please describe where and why, so that others can better
understand both the requirement and the security implications.
If it is intended that this be used mainly for developer debug and not
to be shipped in the mainline kernel then let's get this info into the
changelog as well.
next prev parent reply other threads:[~2021-01-12 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 21:35 [PATCH] lib/hexdump: introduce DUMP_PREFIX_UNHASHED for unhashed addresses Timur Tabi
2021-01-11 10:10 ` Petr Mladek
2021-01-12 1:30 ` Andrew Morton [this message]
2021-01-15 2:56 ` Timur Tabi
2021-01-15 9:21 ` Petr Mladek
2021-01-16 20:54 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111173009.fe2383539e5ca2c23b135262@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=roman.fietze@magna.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=timur@tabi.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox