Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

Rob Herring
2021-01-11T22:15:35Z

On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote:
> Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add
> swing setting for adjusting DP tx PHY swing
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 60585a4..4eb0ea3 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,16 @@ properties:
> description: used for reset chip control, RESET_N pin B7.
> maxItems: 1
>
> + analogix,swing-setting:
> + type: uint8-array

Humm, this should have be rejected by the meta-schema.

> + $ref: /schemas/types.yaml#/definitions/uint32-array

This is how types are defined other than boolean or nodes (object).

> + description: an array of swing register setting for DP tx PHY
> +
> + analogix,mipi-dpi-in:
> + type: int
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: indicate the MIPI rx signal type is DPI or DSI

Why does this need to be in DT, you should be able to determine this
based on what you are connected to.

> +
> ports:
> type: object
>
> @@ -49,8 +59,8 @@ properties:
> Video port for panel or connector.
>
> required:
> - - port@0
> - - port@1
> + - port@0
> + - port@1
>
> required:
> - compatible
> @@ -72,6 +82,17 @@ examples:
> reg = <0x58>;
> enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> + analogix,swing-setting = <0x00 0x14>, <0x01 0x54>,
> + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>,
> + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>,
> + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>,
> + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>,
> + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>,
> + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>,
> + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>,
> + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>,
> + <0x26 0x40>, <0x27 0x60>;

This is a matrix, which is different from an array type.

> + analogix,mipi-dpi-in = <0>;
>
> ports {
> #address-cells = <1>;
> --
> 2.7.4
>