From: Al Viro <viro@zeniv.linux.org.uk>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, willy@infradead.org, arnd@kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH 0/6] fs: deduplicate compat logic
Date: Tue, 12 Jan 2021 00:58:23 +0000 [thread overview]
Message-ID: <20210112005823.GB3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210112003017.4010304-1-willemdebruijn.kernel@gmail.com>
On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> Use in_compat_syscall() to differentiate compat handling exactly
> where needed, including in nested function calls. Then remove
> duplicated code in callers.
IMO it's a bad idea. Use of in_compat_syscall() is hard to avoid
in some cases, but let's not use it without a good reason. It
makes the code harder to reason about.
next prev parent reply other threads:[~2021-01-12 0:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 0:30 [PATCH 0/6] fs: deduplicate compat logic Willem de Bruijn
2021-01-12 0:30 ` [PATCH 1/6] selftests/filesystems: add initial select and poll selftest Willem de Bruijn
2021-01-12 0:30 ` [PATCH 2/6] select: deduplicate compat logic Willem de Bruijn
2021-01-12 0:30 ` [PATCH 3/6] ppoll: " Willem de Bruijn
2021-01-12 0:30 ` [PATCH 4/6] epoll: " Willem de Bruijn
2021-01-12 0:30 ` [PATCH 5/6] compat: add set_maybe_compat_user_sigmask helper Willem de Bruijn
2021-01-12 7:11 ` kernel test robot
2021-01-12 0:30 ` [PATCH 6/6] io_pgetevents: deduplicate compat logic Willem de Bruijn
2021-01-12 0:58 ` Al Viro [this message]
2021-01-12 1:16 ` [PATCH 0/6] fs: " Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112005823.GB3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox