From: kernel test robot <lkp@intel.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
schwab@linux-m68k.org
Cc: kbuild-all@lists.01.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/vdso: fix clock_gettime_fallback for vdso32
Date: Tue, 12 Jan 2021 06:19:20 +0800 [thread overview]
Message-ID: <202101120634.ToUhKEeN-lkp@intel.com> (raw)
In-Reply-To: <77cb8f5e668a2f6e00ea6e90d5f4f37763957b5b.1610383963.git.christophe.leroy@csgroup.eu>
[-- Attachment #1: Type: text/plain, Size: 5962 bytes --]
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.11-rc3 next-20210111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-vdso-fix-clock_gettime_fallback-for-vdso32/20210112-005359
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/49b084da4df1e1cf12240826b7d6db743c761e7c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christophe-Leroy/powerpc-vdso-fix-clock_gettime_fallback-for-vdso32/20210112-005359
git checkout 49b084da4df1e1cf12240826b7d6db743c761e7c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/vdso/datapage.h:137,
from arch/powerpc/include/asm/vdso_datapage.h:39,
from arch/powerpc/kernel/asm-offsets.c:37:
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_gettime_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: error: '__NR_clock_gettime64' undeclared (first use in this function)
113 | return do_syscall_2(__NR_clock_gettime64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_getres_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:119:22: error: '__NR_clock_getres_time64' undeclared (first use in this function)
119 | return do_syscall_2(__NR_clock_getres_time64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/vdso/datapage.h:137,
from arch/powerpc/include/asm/vdso_datapage.h:39,
from arch/powerpc/kernel/asm-offsets.c:37:
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_gettime_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: error: '__NR_clock_gettime64' undeclared (first use in this function)
113 | return do_syscall_2(__NR_clock_gettime64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_getres_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:119:22: error: '__NR_clock_getres_time64' undeclared (first use in this function)
119 | return do_syscall_2(__NR_clock_getres_time64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1206: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from include/vdso/datapage.h:137,
from arch/powerpc/include/asm/vdso_datapage.h:39,
from arch/powerpc/kernel/asm-offsets.c:37:
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_gettime_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: error: '__NR_clock_gettime64' undeclared (first use in this function)
113 | return do_syscall_2(__NR_clock_gettime64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/vdso/gettimeofday.h:113:22: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/include/asm/vdso/gettimeofday.h: In function 'clock_getres_fallback':
>> arch/powerpc/include/asm/vdso/gettimeofday.h:119:22: error: '__NR_clock_getres_time64' undeclared (first use in this function)
119 | return do_syscall_2(__NR_clock_getres_time64, _clkid, (unsigned long)_ts);
| ^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1206: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/__NR_clock_gettime64 +113 arch/powerpc/include/asm/vdso/gettimeofday.h
109
110 static __always_inline
111 int clock_gettime_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
112 {
> 113 return do_syscall_2(__NR_clock_gettime64, _clkid, (unsigned long)_ts);
114 }
115
116 static __always_inline
117 int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
118 {
> 119 return do_syscall_2(__NR_clock_getres_time64, _clkid, (unsigned long)_ts);
120 }
121
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72492 bytes --]
next prev parent reply other threads:[~2021-01-11 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 16:52 [PATCH v2] powerpc/vdso: fix clock_gettime_fallback for vdso32 Christophe Leroy
2021-01-11 22:19 ` kernel test robot [this message]
2021-01-12 1:13 ` Michael Ellerman
2021-01-12 12:48 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101120634.ToUhKEeN-lkp@intel.com \
--to=lkp@intel.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox