From: Jiri Olsa <jolsa@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Song Liu <songliubraving@fb.com>, Ian Rogers <irogers@google.com>,
Stephane Eranian <eranian@google.com>,
Alexei Budankov <abudankov@huawei.com>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCHv6 0/4] perf: Add mmap2 build id support
Date: Tue, 12 Jan 2021 10:19:37 +0100 [thread overview]
Message-ID: <20210112091937.GA1252618@krava> (raw)
In-Reply-To: <20210112024958.4utm7ijkpluu3g36@ast-mbp>
On Mon, Jan 11, 2021 at 06:49:58PM -0800, Alexei Starovoitov wrote:
> On Mon, Jan 11, 2021 at 10:38:19PM +0100, Jiri Olsa wrote:
> > hi,
> > adding the support to have buildid stored in mmap2 event,
> > so we can bypass the final perf record hunt on build ids.
> >
> > This patchset allows perf to record build ID in mmap2 event,
> > and adds perf tooling to store/download binaries to .debug
> > cache based on these build IDs.
> >
> > Note that the build id retrieval code is stolen from bpf
> > code, where it's been used (together with file offsets)
> > to replace IPs in user space stack traces. It's now added
> > under lib directory.
> >
> > v6 changes:
> > - last 4 patches rebased Arnaldo's perf/core
>
> There were no issues with v5 as far as I can remember.
> This is just a resubmit to get it landed ?
yes, exactly
> Last time we couldn't quite figure out which tree to go through.
> I think the recommend path was to go via bpf-next.
> Is it still the case?
bpf-next would be best for kernel changes,
perf: Add build id data in mmap2 event
bpf: Add size arg to build_id_parse function
bpf: Move stack_map_get_build_id into lib
the 'perf buildid-cache' change needs to go through Arnaldo's tree,
because it depends on changes he already pulled in
thanks,
jirka
next prev parent reply other threads:[~2021-01-12 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 21:38 [PATCHv6 0/4] perf: Add mmap2 build id support Jiri Olsa
2021-01-11 21:38 ` [PATCH 1/4] bpf: Move stack_map_get_build_id into lib Jiri Olsa
2021-01-11 21:38 ` [PATCH 2/4] bpf: Add size arg to build_id_parse function Jiri Olsa
2021-01-11 21:38 ` [PATCH 3/4] perf: Add build id data in mmap2 event Jiri Olsa
2021-01-11 21:38 ` [PATCH 4/4] perf buildid-cache: Add support to add build ids from perf data Jiri Olsa
2021-01-12 2:49 ` [PATCHv6 0/4] perf: Add mmap2 build id support Alexei Starovoitov
2021-01-12 9:19 ` Jiri Olsa [this message]
2021-01-14 3:26 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112091937.GA1252618@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox