From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read
Date: Tue, 12 Jan 2021 20:41:16 +0100 [thread overview]
Message-ID: <20210112194116.GA50007@kunai> (raw)
In-Reply-To: <20210112164130.47895-3-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
> +static int adv7511_edid_rd(struct v4l2_subdev *sd, uint16_t len, uint8_t *buf)
> {
> struct adv7511_state *state = get_adv7511_state(sd);
> + s32 len;
And 'len' here shadows the function argument :( Ok, I need to resend
this patch. Still, looking forward to a comment if an approach like this
is acceptable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-12 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:41 [PATCH RFC 0/3] treewide: remove open coded SMBus block transfers Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 1/3] media: i2c: adv7842: remove open coded version of SMBus block write Wolfram Sang
2021-01-18 9:24 ` Hans Verkuil
2021-01-18 9:32 ` Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read Wolfram Sang
2021-01-12 16:44 ` Wolfram Sang
2021-01-12 19:41 ` Wolfram Sang [this message]
2021-01-18 9:22 ` Hans Verkuil
2021-01-18 9:33 ` Wolfram Sang
2021-01-12 16:41 ` [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write Wolfram Sang
2021-01-14 0:48 ` Corey Minyard
2021-01-14 14:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112194116.GA50007@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox