* [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static @ 2021-01-12 19:57 Souptick Joarder 2021-01-12 21:55 ` Alex Deucher 2021-01-13 1:19 ` Huang Rui 0 siblings, 2 replies; 6+ messages in thread From: Souptick Joarder @ 2021-01-12 19:57 UTC (permalink / raw) To: alexander.deucher, christian.koenig, airlied, daniel, Xiaojian.Du, ray.huang, evan.quan, lijo.lazar, Jinzhou.Su, Xiaomeng.Hou Cc: amd-gfx, dri-devel, linux-kernel, Souptick Joarder kernel test robot throws below warnings -> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes] Mark vangogh_clk_dpm_is_enabled() as static. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c index 75ddcad..3ffe56e 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, return 0; } -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, enum smu_clk_type clk_type) { enum smu_feature_mask feature_id = 0; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static 2021-01-12 19:57 [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static Souptick Joarder @ 2021-01-12 21:55 ` Alex Deucher 2021-01-13 1:19 ` Huang Rui 1 sibling, 0 replies; 6+ messages in thread From: Alex Deucher @ 2021-01-12 21:55 UTC (permalink / raw) To: Souptick Joarder Cc: Deucher, Alexander, Christian Koenig, Dave Airlie, Daniel Vetter, Xiaojian Du, Huang Rui, Quan, Evan, Lazar, Lijo, Jinzhou.Su, Xiaomeng.Hou, Maling list - DRI developers, amd-gfx list, LKML On Tue, Jan 12, 2021 at 3:23 PM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > kernel test robot throws below warnings -> > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] > > Mark vangogh_clk_dpm_is_enabled() as static. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > index 75ddcad..3ffe56e 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, > return 0; > } > > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > enum smu_clk_type clk_type) > { > enum smu_feature_mask feature_id = 0; > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static 2021-01-12 19:57 [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static Souptick Joarder 2021-01-12 21:55 ` Alex Deucher @ 2021-01-13 1:19 ` Huang Rui 2021-01-13 2:13 ` Alex Deucher 1 sibling, 1 reply; 6+ messages in thread From: Huang Rui @ 2021-01-13 1:19 UTC (permalink / raw) To: Souptick Joarder Cc: Deucher, Alexander, Koenig, Christian, airlied@linux.ie, daniel@ffwll.ch, Du, Xiaojian, Quan, Evan, Lazar, Lijo, Su, Jinzhou (Joe), Hou, Xiaomeng (Matthew), amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > kernel test robot throws below warnings -> > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] > > Mark vangogh_clk_dpm_is_enabled() as static. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > index 75ddcad..3ffe56e 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, > return 0; > } > > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > enum smu_clk_type clk_type) Ah, I have another patch which will use this function in another file. Thanks, Ray > { > enum smu_feature_mask feature_id = 0; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static 2021-01-13 1:19 ` Huang Rui @ 2021-01-13 2:13 ` Alex Deucher 2021-01-13 2:21 ` Huang Rui 0 siblings, 1 reply; 6+ messages in thread From: Alex Deucher @ 2021-01-13 2:13 UTC (permalink / raw) To: Huang Rui Cc: Souptick Joarder, Su, Jinzhou (Joe), Du, Xiaojian, airlied@linux.ie, Lazar, Lijo, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Hou, Xiaomeng (Matthew), dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Deucher, Alexander, Quan, Evan, Koenig, Christian On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote: > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > kernel test robot throws below warnings -> > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > > [-Wmissing-prototypes] > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' > > [-Wmissing-prototypes] > > > > Mark vangogh_clk_dpm_is_enabled() as static. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > --- > > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > index 75ddcad..3ffe56e 100644 > > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, > > return 0; > > } > > > > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > enum smu_clk_type clk_type) > > Ah, I have another patch which will use this function in another file. > I can drop it if you plan to land those patches soon. Alex > Thanks, > Ray > > > { > > enum smu_feature_mask feature_id = 0; > > -- > > 1.9.1 > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static 2021-01-13 2:13 ` Alex Deucher @ 2021-01-13 2:21 ` Huang Rui 2021-01-13 2:30 ` Huang Rui 0 siblings, 1 reply; 6+ messages in thread From: Huang Rui @ 2021-01-13 2:21 UTC (permalink / raw) To: Alex Deucher Cc: Souptick Joarder, Su, Jinzhou (Joe), Du, Xiaojian, airlied@linux.ie, Lazar, Lijo, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Hou, Xiaomeng (Matthew), dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Deucher, Alexander, Quan, Evan, Koenig, Christian On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote: > On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote: > > > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > > kernel test robot throws below warnings -> > > > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > > > [-Wmissing-prototypes] > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' > > > [-Wmissing-prototypes] > > > > > > Mark vangogh_clk_dpm_is_enabled() as static. > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > --- > > > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > index 75ddcad..3ffe56e 100644 > > > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, > > > return 0; > > > } > > > > > > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > > enum smu_clk_type clk_type) > > > > Ah, I have another patch which will use this function in another file. > > > > I can drop it if you plan to land those patches soon. Thanks Alex. Yes, I will upload them after verify them on the new firmware today. Thanks, Ray > > Alex > > > > Thanks, > > Ray > > > > > { > > > enum smu_feature_mask feature_id = 0; > > > -- > > > 1.9.1 > > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cray.huang%40amd.com%7C19fce6891f2d4f6df7de08d8b768c8a9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637461007972405505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=v2JGTkklMHOE2hN1s4dYZ1hT7ctLeUHpwkpn1M3nyi8%3D&reserved=0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static 2021-01-13 2:21 ` Huang Rui @ 2021-01-13 2:30 ` Huang Rui 0 siblings, 0 replies; 6+ messages in thread From: Huang Rui @ 2021-01-13 2:30 UTC (permalink / raw) To: Alex Deucher Cc: Souptick Joarder, Su, Jinzhou (Joe), Du, Xiaojian, airlied@linux.ie, Lazar, Lijo, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Hou, Xiaomeng (Matthew), dri-devel@lists.freedesktop.org, daniel@ffwll.ch, Deucher, Alexander, Quan, Evan, Koenig, Christian On Wed, Jan 13, 2021 at 10:21:26AM +0800, Huang Rui wrote: > On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote: > > On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote: > > > > > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > > > kernel test robot throws below warnings -> > > > > > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > > > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > > > > [-Wmissing-prototypes] > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > > > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' > > > > [-Wmissing-prototypes] > > > > > > > > Mark vangogh_clk_dpm_is_enabled() as static. > > > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > --- > > > > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > > index 75ddcad..3ffe56e 100644 > > > > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c > > > > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu, > > > > return 0; > > > > } > > > > > > > > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > > > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu, > > > > enum smu_clk_type clk_type) > > > > > > Ah, I have another patch which will use this function in another file. > > > > > > > I can drop it if you plan to land those patches soon. > > Thanks Alex. Yes, I will upload them after verify them on the new firmware > today. Sorry Alex, I miss read the function name as "cclk_dpm". This patch is good, please go forward to apply it. Reviewed-by: Huang Rui <ray.huang@amd.com> Thanks, Ray > > Thanks, > Ray > > > > > Alex > > > > > > > Thanks, > > > Ray > > > > > > > { > > > > enum smu_feature_mask feature_id = 0; > > > > -- > > > > 1.9.1 > > > > > > > _______________________________________________ > > > amd-gfx mailing list > > > amd-gfx@lists.freedesktop.org > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cray.huang%40amd.com%7C19fce6891f2d4f6df7de08d8b768c8a9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637461007972405505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=v2JGTkklMHOE2hN1s4dYZ1hT7ctLeUHpwkpn1M3nyi8%3D&reserved=0 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-13 2:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-12 19:57 [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static Souptick Joarder 2021-01-12 21:55 ` Alex Deucher 2021-01-13 1:19 ` Huang Rui 2021-01-13 2:13 ` Alex Deucher 2021-01-13 2:21 ` Huang Rui 2021-01-13 2:30 ` Huang Rui
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox