public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Al Cooper" <alcooperx@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>
Subject: Re: [PATCH V4 1/3] dt-bindings: phy: brcm, brcmstb-usb-phy: convert to the json-schema
Date: Tue, 12 Jan 2021 21:17:39 -0600	[thread overview]
Message-ID: <20210113031739.GA1460774@robh.at.kernel.org> (raw)
In-Reply-To: <20210106205838.10964-1-zajec5@gmail.com>

On Wed, 06 Jan 2021 21:58:36 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Changes that require mentioning:
> 1. interrupt-names
>    Name "wakeup" was changed to the "wake". It matches example and what
>    Linux driver looks for in the first place
> 2. brcm,ipp and brcm,ioc
>    Both were described as booleans with 0 / 1 values. In examples they
>    were integers and Linux checks for int as well. Both got uint32.
> 3. Added minimal description
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Add Al as maintainer
> V3: Define "reg" and "reg-names" directly in the properties
> V4: additionalProperties: false
>     Fix example to use brcm,syscon-piarbctl (with the prefix)
> ---
>  .../bindings/phy/brcm,brcmstb-usb-phy.txt     |  86 --------
>  .../bindings/phy/brcm,brcmstb-usb-phy.yaml    | 193 ++++++++++++++++++
>  2 files changed, 193 insertions(+), 86 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  parent reply	other threads:[~2021-01-13  3:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 20:58 [PATCH V4 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema Rafał Miłecki
2021-01-06 20:58 ` [PATCH V4 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding Rafał Miłecki
2021-01-06 20:58 ` [PATCH V4 3/3] phy: phy-brcm-usb: support PHY on the BCM4908 Rafał Miłecki
2021-01-13  3:17 ` Rob Herring [this message]
2021-01-13  4:52 ` [PATCH V4 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema Florian Fainelli
2021-01-13 14:15 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113031739.GA1460774@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox